Changeset 87292 in webkit


Ignore:
Timestamp:
May 25, 2011 4:55:13 AM (13 years ago)
Author:
keishi@webkit.org
Message:

2011-05-25 Keishi Hattori <​keishi@webkit.org>

Reviewed by Kent Tamura.

Move ElementWithPseudoId to separate file
​https://bugs.webkit.org/show_bug.cgi?id=61430

No new tests because no behavior changes.

  • CMakeLists.txt: Added ElementWithPseudoId.cpp
  • GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
  • WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
  • WebCore.pro: Added ElementWithPseudoId.{h,cpp}
  • WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
  • WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
  • html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
  • html/shadow/ElementWithPseudoId.cpp: Added. (WebCore::ElementWithPseudoId::shadowPseudoId):
  • html/shadow/ElementWithPseudoId.h: Added. (WebCore::ElementWithPseudoId::create): (WebCore::ElementWithPseudoId::ElementWithPseudoId):
Location:
trunk/Source/WebCore
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r87197 r87292  
    878878    html/parser/XSSFilter.cpp
    879879
     880    html/shadow/ElementWithPseudoId.cpp
    880881    html/shadow/DetailsMarkerControl.cpp
    881882    html/shadow/MediaControls.cpp

  • trunk/Source/WebCore/ChangeLog

    r87290 r87292  
     12011-05-25  Keishi Hattori  <keishi@webkit.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Move ElementWithPseudoId to separate file
     6        https://bugs.webkit.org/show_bug.cgi?id=61430
     7
     8        No new tests because no behavior changes.
     9
     10        * CMakeLists.txt: Added ElementWithPseudoId.cpp
     11        * GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
     12        * WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
     13        * WebCore.pro: Added ElementWithPseudoId.{h,cpp}
     14        * WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
     15        * WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
     16        * html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
     17        * html/shadow/ElementWithPseudoId.cpp: Added.
     18        (WebCore::ElementWithPseudoId::shadowPseudoId):
     19        * html/shadow/ElementWithPseudoId.h: Added.
     20        (WebCore::ElementWithPseudoId::create):
     21        (WebCore::ElementWithPseudoId::ElementWithPseudoId):
     22
    1232011-05-25  Alexis Menard  <alexis.menard@openbossa.org>
    224

  • trunk/Source/WebCore/GNUmakefile.list.am

    r87228 r87292  
    18291829        Source/WebCore/html/parser/XSSFilter.cpp \
    18301830        Source/WebCore/html/parser/XSSFilter.h \
     1831        Source/WebCore/html/shadow/ElementWithPseudoId.cpp \
     1832        Source/WebCore/html/shadow/ElementWithPseudoId.h \
    18311833        Source/WebCore/html/shadow/DetailsMarkerControl.cpp \
    18321834        Source/WebCore/html/shadow/DetailsMarkerControl.h \

  • trunk/Source/WebCore/WebCore.gypi

    r87228 r87292  
    31763176            'html/parser/XSSFilter.cpp',
    31773177            'html/parser/XSSFilter.h',
     3178            'html/shadow/ElementWithPseudoId.cpp',
     3179            'html/shadow/ElementWithPseudoId.h',
    31783180            'html/shadow/DetailsMarkerControl.cpp',
    31793181            'html/shadow/DetailsMarkerControl.h',

  • trunk/Source/WebCore/WebCore.pro

    r87276 r87292  
    797797    html/parser/TextViewSourceParser.cpp \
    798798    html/parser/XSSFilter.cpp \
     799    html/shadow/ElementWithPseudoId.cpp \
    799800    html/shadow/DetailsMarkerControl.cpp \
    800801    html/shadow/MediaControls.cpp \
    … …  
    17471748    html/shadow/MediaControlElements.h \
    17481749    html/shadow/DetailsMarkerControl.h \
     1750    html/shadow/ElementWithPseudoId.h \
    17491751    inspector/ConsoleMessage.h \
    17501752    inspector/DOMNodeHighlighter.h \

  • trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj

    r87228 r87292  
    5687456874                                >
    5687556875                                <File
     56876                                        RelativePath="..\html\shadow\ElementWithPseudoId.cpp"
     56877                                        >
     56878                                </File>
     56879                                <File
     56880                                        RelativePath="..\html\shadow\ElementWithPseudoId.h"
     56881                                        >
     56882                                </File>
     56883                                <File
    5687656884                                        RelativePath="..\html\shadow\DetailsMarkerControl.cpp"
    5687756885                                        >

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r87231 r87292  
    53395339                C105DA620F3AA68F001DD44F /* TextEncodingDetectorICU.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C105DA610F3AA68F001DD44F /* TextEncodingDetectorICU.cpp */; };
    53405340                C105DA640F3AA6B8001DD44F /* TextEncodingDetector.h in Headers */ = {isa = PBXBuildFile; fileRef = C105DA630F3AA6B8001DD44F /* TextEncodingDetector.h */; };
     5341                C39509B6138D05D400912E52 /* ElementWithPseudoId.h in Headers */ = {isa = PBXBuildFile; fileRef = C39509B4138D05D400912E52 /* ElementWithPseudoId.h */; };
     5342                C39509B7138D05D400912E52 /* ElementWithPseudoId.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C39509B5138D05D400912E52 /* ElementWithPseudoId.cpp */; };
    53415343                C50B561612119D23008B46E0 /* GroupSettings.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C50B561412119D23008B46E0 /* GroupSettings.cpp */; };
    53425344                C50B561712119D23008B46E0 /* GroupSettings.h in Headers */ = {isa = PBXBuildFile; fileRef = C50B561512119D23008B46E0 /* GroupSettings.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    1183211834                C105DA610F3AA68F001DD44F /* TextEncodingDetectorICU.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TextEncodingDetectorICU.cpp; sourceTree = "<group>"; };
    1183311835                C105DA630F3AA6B8001DD44F /* TextEncodingDetector.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextEncodingDetector.h; sourceTree = "<group>"; };
     11836                C39509B4138D05D400912E52 /* ElementWithPseudoId.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ElementWithPseudoId.h; sourceTree = "<group>"; };
     11837                C39509B5138D05D400912E52 /* ElementWithPseudoId.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ElementWithPseudoId.cpp; sourceTree = "<group>"; };
    1183411838                C50B561412119D23008B46E0 /* GroupSettings.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GroupSettings.cpp; sourceTree = "<group>"; };
    1183511839                C50B561512119D23008B46E0 /* GroupSettings.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GroupSettings.h; sourceTree = "<group>"; };
    … …  
    1352613530                                A7C9ABF61357A3BF00F5503F /* DetailsMarkerControl.cpp */,
    1352713531                                A7C9ABF71357A3BF00F5503F /* DetailsMarkerControl.h */,
     13532                                C39509B5138D05D400912E52 /* ElementWithPseudoId.cpp */,
     13533                                C39509B4138D05D400912E52 /* ElementWithPseudoId.h */,
    1352813534                                417253A81354BBBC00360F2A /* MediaControlElements.cpp */,
    1352913535                                417253A91354BBBC00360F2A /* MediaControlElements.h */,
    … …  
    2098720993                                63F5D4F70E8C4B7100C0BD04 /* ElementRareData.h in Headers */,
    2098820994                                E415F1840D9A1A830033CE97 /* ElementTimeControl.h in Headers */,
     20995                                C39509B6138D05D400912E52 /* ElementWithPseudoId.h in Headers */,
    2098920996                                A8CFF6BE0A156118000A4234 /* EllipsisBox.h in Headers */,
    2099020997                                F55B3DBC1251F12D003EF269 /* EmailInputType.h in Headers */,
    … …  
    2384623853                                ED501DC60B249F2900AE18D9 /* EditorMac.mm in Sources */,
    2384723854                                A8C4A80809D563270003AC8D /* Element.cpp in Sources */,
     23855                                C39509B7138D05D400912E52 /* ElementWithPseudoId.cpp in Sources */,
    2384823856                                A8CFF6CB0A1561CD000A4234 /* EllipsisBox.cpp in Sources */,
    2384923857                                F55B3DBB1251F12D003EF269 /* EmailInputType.cpp in Sources */,

  • trunk/Source/WebCore/html/ValidationMessage.cpp

    r86224 r87292  
    3535#include "CSSStyleSelector.h"
    3636#include "CSSValueKeywords.h"
     37#include "ElementWithPseudoId.h"
    3738#include "FormAssociatedElement.h"
    3839#include "HTMLBRElement.h"
    … …  
    105106}
    106107
    107 class ElementWithPseudoId : public HTMLElement {
    108 public:
    109     static PassRefPtr<HTMLElement> create(Document* doc, const AtomicString& pseudoName)
    110     {
    111         return adoptRef(new ElementWithPseudoId(doc, pseudoName));
    112     }
    113 
    114 protected:
    115     ElementWithPseudoId(Document* doc, const AtomicString& pseudoName)
    116         : HTMLElement(divTag, doc)
    117         , m_pseudoName(pseudoName) { };
    118     virtual const AtomicString& shadowPseudoId() const { return m_pseudoName; }
    119 
    120 private:
    121     AtomicString m_pseudoName;
    122 };
    123 
    124108static void adjustBubblePosition(const IntRect& hostRect, HTMLElement* bubble)
    125109{
Note: See TracChangeset for help on using the changeset viewer.