Changeset 87301 in webkit
- Timestamp:
- May 25, 2011 9:50:53 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r87298 r87301 1 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r87229. 4 http://trac.webkit.org/changeset/87229 5 https://bugs.webkit.org/show_bug.cgi?id=61445 6 7 Lots of tests crashing in 8 CFNetwork!URLResponse::createFilenameFromResponseHeaders on 9 Windows XP (Requested by aroben on #webkit). 10 11 * platform/network/ResourceResponseBase.cpp: 12 (WebCore::ResourceResponseBase::adopt): 13 (WebCore::ResourceResponseBase::suggestedFilename): 14 (WebCore::ResourceResponseBase::setSuggestedFilename): 15 (WebCore::ResourceResponseBase::httpStatusText): 16 (WebCore::ResourceResponseBase::setHTTPStatusText): 17 (WebCore::ResourceResponseBase::httpHeaderField): 18 (WebCore::ResourceResponseBase::setHTTPHeaderField): 19 (WebCore::ResourceResponseBase::httpHeaderFields): 20 (WebCore::ResourceResponseBase::isAttachment): 21 (WebCore::ResourceResponseBase::setLastModifiedDate): 22 (WebCore::ResourceResponseBase::lastModifiedDate): 23 (WebCore::ResourceResponseBase::wasCached): 24 (WebCore::ResourceResponseBase::connectionReused): 25 (WebCore::ResourceResponseBase::setConnectionReused): 26 (WebCore::ResourceResponseBase::connectionID): 27 (WebCore::ResourceResponseBase::setConnectionID): 28 (WebCore::ResourceResponseBase::resourceLoadTiming): 29 (WebCore::ResourceResponseBase::setResourceLoadTiming): 30 (WebCore::ResourceResponseBase::resourceLoadInfo): 31 (WebCore::ResourceResponseBase::setResourceLoadInfo): 32 * platform/network/ResourceResponseBase.h: 33 * platform/network/cf/ResourceResponse.h: 34 (WebCore::ResourceResponse::ResourceResponse): 35 * platform/network/cf/ResourceResponseCFNet.cpp: 36 (WebCore::ResourceResponse::platformLazyInit): 37 * platform/network/mac/ResourceResponseMac.mm: 38 (WebCore::ResourceResponse::platformLazyInit): 39 1 40 2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org> 2 41 -
trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp
r87229 r87301 109 109 response->setHTTPStatusText(data->m_httpStatusText); 110 110 111 response->lazyInit( CommonAndUncommonFields);111 response->lazyInit(AllFields); 112 112 response->m_httpHeaderFields.adopt(data->m_httpHeaders.release()); 113 113 response->setLastModifiedDate(data->m_lastModifiedDate); … … 206 206 const String& ResourceResponseBase::suggestedFilename() const 207 207 { 208 lazyInit( AllFields);208 lazyInit(CommonFieldsOnly); 209 209 210 210 return m_suggestedFilename; … … 213 213 void ResourceResponseBase::setSuggestedFilename(const String& suggestedName) 214 214 { 215 lazyInit( AllFields);215 lazyInit(CommonFieldsOnly); 216 216 m_isNull = false; 217 217 … … 235 235 const String& ResourceResponseBase::httpStatusText() const 236 236 { 237 lazyInit( CommonAndUncommonFields);237 lazyInit(AllFields); 238 238 239 239 return m_httpStatusText; … … 242 242 void ResourceResponseBase::setHTTPStatusText(const String& statusText) 243 243 { 244 lazyInit( CommonAndUncommonFields);244 lazyInit(AllFields); 245 245 246 246 m_httpStatusText = statusText; … … 256 256 return value; 257 257 258 lazyInit( CommonAndUncommonFields);258 lazyInit(AllFields); 259 259 260 260 return m_httpHeaderFields.get(name); … … 270 270 return value; 271 271 272 lazyInit( CommonAndUncommonFields);272 lazyInit(AllFields); 273 273 274 274 return m_httpHeaderFields.get(name); … … 277 277 void ResourceResponseBase::setHTTPHeaderField(const AtomicString& name, const String& value) 278 278 { 279 lazyInit( CommonAndUncommonFields);279 lazyInit(AllFields); 280 280 281 281 DEFINE_STATIC_LOCAL(const AtomicString, ageHeader, ("age")); … … 301 301 const HTTPHeaderMap& ResourceResponseBase::httpHeaderFields() const 302 302 { 303 lazyInit( CommonAndUncommonFields);303 lazyInit(AllFields); 304 304 305 305 return m_httpHeaderFields; … … 465 465 bool ResourceResponseBase::isAttachment() const 466 466 { 467 lazyInit( CommonAndUncommonFields);467 lazyInit(AllFields); 468 468 469 469 DEFINE_STATIC_LOCAL(const AtomicString, headerName, ("content-disposition")); … … 479 479 void ResourceResponseBase::setLastModifiedDate(time_t lastModifiedDate) 480 480 { 481 lazyInit( CommonAndUncommonFields);481 lazyInit(AllFields); 482 482 483 483 m_lastModifiedDate = lastModifiedDate; … … 486 486 time_t ResourceResponseBase::lastModifiedDate() const 487 487 { 488 lazyInit( CommonAndUncommonFields);488 lazyInit(AllFields); 489 489 490 490 return m_lastModifiedDate; … … 493 493 bool ResourceResponseBase::wasCached() const 494 494 { 495 lazyInit( CommonAndUncommonFields);495 lazyInit(AllFields); 496 496 497 497 return m_wasCached; … … 505 505 bool ResourceResponseBase::connectionReused() const 506 506 { 507 lazyInit( CommonAndUncommonFields);507 lazyInit(AllFields); 508 508 509 509 return m_connectionReused; … … 512 512 void ResourceResponseBase::setConnectionReused(bool connectionReused) 513 513 { 514 lazyInit( CommonAndUncommonFields);514 lazyInit(AllFields); 515 515 516 516 m_connectionReused = connectionReused; … … 519 519 unsigned ResourceResponseBase::connectionID() const 520 520 { 521 lazyInit( CommonAndUncommonFields);521 lazyInit(AllFields); 522 522 523 523 return m_connectionID; … … 526 526 void ResourceResponseBase::setConnectionID(unsigned connectionID) 527 527 { 528 lazyInit( CommonAndUncommonFields);528 lazyInit(AllFields); 529 529 530 530 m_connectionID = connectionID; … … 533 533 ResourceLoadTiming* ResourceResponseBase::resourceLoadTiming() const 534 534 { 535 lazyInit( CommonAndUncommonFields);535 lazyInit(AllFields); 536 536 537 537 return m_resourceLoadTiming.get(); … … 540 540 void ResourceResponseBase::setResourceLoadTiming(PassRefPtr<ResourceLoadTiming> resourceLoadTiming) 541 541 { 542 lazyInit( CommonAndUncommonFields);542 lazyInit(AllFields); 543 543 544 544 m_resourceLoadTiming = resourceLoadTiming; … … 547 547 PassRefPtr<ResourceLoadInfo> ResourceResponseBase::resourceLoadInfo() const 548 548 { 549 lazyInit( CommonAndUncommonFields);549 lazyInit(AllFields); 550 550 551 551 return m_resourceLoadInfo.get(); … … 554 554 void ResourceResponseBase::setResourceLoadInfo(PassRefPtr<ResourceLoadInfo> loadInfo) 555 555 { 556 lazyInit( CommonAndUncommonFields);556 lazyInit(AllFields); 557 557 558 558 m_resourceLoadInfo = loadInfo; -
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
r87229 r87301 133 133 Uninitialized, 134 134 CommonFieldsOnly, 135 CommonAndUncommonFields,136 135 AllFields 137 136 }; -
trunk/Source/WebCore/platform/network/cf/ResourceResponse.h
r87229 r87301 45 45 public: 46 46 ResourceResponse() 47 : m_initLevel( CommonAndUncommonFields)47 : m_initLevel(AllFields) 48 48 { 49 49 } … … 67 67 ResourceResponse(const KURL& url, const String& mimeType, long long expectedLength, const String& textEncodingName, const String& filename) 68 68 : ResourceResponseBase(url, mimeType, expectedLength, textEncodingName, filename) 69 , m_initLevel( CommonAndUncommonFields)69 , m_initLevel(AllFields) 70 70 { 71 71 } -
trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp
r87229 r87301 44 44 45 45 static CFStringRef const commonHeaderFields[] = { 46 CFSTR("Age"), CFSTR("Cache-Control"), CFSTR(" Content-Type"), CFSTR("Date"), CFSTR("Etag"), CFSTR("Expires"), CFSTR("Last-Modified"), CFSTR("Pragma")46 CFSTR("Age"), CFSTR("Cache-Control"), CFSTR("Date"), CFSTR("Etag"), CFSTR("Expires"), CFSTR("Last-Modified"), CFSTR("Pragma") 47 47 }; 48 48 static const int numCommonHeaderFields = sizeof(commonHeaderFields) / sizeof(CFStringRef); … … 99 99 m_lastModifiedDate = toTimeT(CFURLResponseGetLastModifiedDate(m_cfResponse.get())); 100 100 101 RetainPtr<CFStringRef> suggestedFilename(AdoptCF, CFURLResponseCopySuggestedFilename(m_cfResponse.get())); 102 m_suggestedFilename = suggestedFilename.get(); 103 101 104 CFHTTPMessageRef httpResponse = CFURLResponseGetHTTPResponse(m_cfResponse.get()); 102 105 if (httpResponse) { … … 114 117 } 115 118 116 if (m_initLevel < CommonAndUncommonFields && initLevel >= CommonAndUncommonFields) {119 if (m_initLevel < AllFields && initLevel >= AllFields) { 117 120 CFHTTPMessageRef httpResponse = CFURLResponseGetHTTPResponse(m_cfResponse.get()); 118 121 if (httpResponse) { … … 129 132 } 130 133 } 131 132 if (m_initLevel < AllFields && initLevel >= AllFields) {133 RetainPtr<CFStringRef> suggestedFilename(AdoptCF, CFURLResponseCopySuggestedFilename(m_cfResponse.get()));134 m_suggestedFilename = suggestedFilename.get();135 }136 134 137 135 m_initLevel = initLevel; -
trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm
r87229 r87301 45 45 46 46 static NSString* const commonHeaderFields[] = { 47 @"Age", @"Cache-Control", @" Content-Type", @"Date", @"Etag", @"Expires", @"Last-Modified", @"Pragma"47 @"Age", @"Cache-Control", @"Date", @"Etag", @"Expires", @"Last-Modified", @"Pragma" 48 48 }; 49 49 static const int numCommonHeaderFields = sizeof(commonHeaderFields) / sizeof(AtomicString*); … … 89 89 m_textEncodingName = m_textEncodingName.substring(1, textEncodingNameLength - 2); 90 90 91 m_suggestedFilename = [m_nsResponse.get() suggestedFilename]; 92 91 93 if ([m_nsResponse.get() isKindOfClass:[NSHTTPURLResponse class]]) { 92 94 NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)m_nsResponse.get(); … … 106 108 } 107 109 108 if (m_initLevel < CommonAndUncommonFields && initLevel >= CommonAndUncommonFields) { 109 if ([m_nsResponse.get() isKindOfClass:[NSHTTPURLResponse class]]) { 110 NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init]; 110 if (m_initLevel < AllFields && initLevel >= AllFields && [m_nsResponse.get() isKindOfClass:[NSHTTPURLResponse class]]) { 111 NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init]; 111 112 112 113 NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)m_nsResponse.get(); 113 114 114 115 116 117 118 115 RetainPtr<NSString> httpStatusLine(AdoptNS, wkCopyNSURLResponseStatusLine(m_nsResponse.get())); 116 if (httpStatusLine) 117 m_httpStatusText = extractReasonPhraseFromHTTPStatusLine(httpStatusLine.get()); 118 else 119 m_httpStatusText = "OK"; 119 120 120 NSDictionary *headers = [httpResponse allHeaderFields]; 121 NSEnumerator *e = [headers keyEnumerator]; 122 while (NSString *name = [e nextObject]) 123 m_httpHeaderFields.set(name, [headers objectForKey:name]); 124 125 [pool drain]; 126 } 121 NSDictionary *headers = [httpResponse allHeaderFields]; 122 NSEnumerator *e = [headers keyEnumerator]; 123 while (NSString *name = [e nextObject]) 124 m_httpHeaderFields.set(name, [headers objectForKey:name]); 125 126 [pool drain]; 127 127 } 128 129 if (m_initLevel < AllFields && initLevel >= AllFields)130 m_suggestedFilename = [m_nsResponse.get() suggestedFilename];131 128 132 129 m_initLevel = initLevel;
Note: See TracChangeset
for help on using the changeset viewer.