Changeset 87315 in webkit

Timestamp:

May 25, 2011 12:28:22 PM (13 years ago)

Author:

caio.oliveira@openbossa.org

Message:

2011-05-25 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] JSC bridge: implement qt_sender without using Scope Chain
​https://bugs.webkit.org/show_bug.cgi?id=61343

Create a stack to keep track of the sender objects. This is simpler than
the similar mechanism in QObject (C++ API), that keeps a stack per-object.

Since we do not support multiple threads, one static stack will be enough for
handling the behavior.

This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

• bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::qtSenderStack): We have one static stack of QObject*. The top of the stack contains the last object that emitted signal that called a JavaScript function.

• bridge/qt/qt_instance.h: (JSC::Bindings::QtInstance::QtSenderStack::top): (JSC::Bindings::QtInstance::QtSenderStack::push): (JSC::Bindings::QtInstance::QtSenderStack::pop): Minimal functionality to manipulate the sender stack.

• bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute): Remove the previous code that modified the scope chain. Push the sender object to the stack before calling the JavaScript function (the "slot" in Qt-speak) and pop it afterwards.

2011-05-25 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] JSC bridge: implement qt_sender without using Scope Chain
​https://bugs.webkit.org/show_bug.cgi?id=61343

Create a 'qt_sender' property in the global object, that returns the top of
the qtSenderStack. This is an alternative implementation for the feature of
providing a way for a function (acting as a Qt 'slot') discover which object
emitted the signal that caused it to be executed.

This reduces the coupling of the Qt bridge and JSC internal implementation. The
patch tries to use as much JSC public API as possible.

This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

• WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls a QWebPagePrivate function to do it.

• Api/qwebframe_p.h:
• Api/qwebframe.cpp: (QWebFramePrivate::didClearedWindowObject): Before emitting the signal mentioned, adds the 'qt_sender' to the fresh global object.

(qtSenderCallback):
Returns the JSObjectRef corresponding to the top of qtSenderStack.

(QWebFramePrivate::addQtSenderToGlobalObject):
Create a property with a qtSenderCallback as getter function in the global object.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bridge/qt/qt_instance.cpp (modified) (2 diffs)
• WebCore/bridge/qt/qt_instance.h (modified) (2 diffs)
• WebCore/bridge/qt/qt_runtime.cpp (modified) (2 diffs)
• WebKit/qt/Api/qwebframe.cpp (modified) (3 diffs)
• WebKit/qt/Api/qwebframe_p.h (modified) (2 diffs)
• WebKit/qt/ChangeLog (modified) (1 diff)
• WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
+        https://bugs.webkit.org/show_bug.cgi?id=61343
+
+        Create a stack to keep track of the sender objects. This is simpler than
+        the similar mechanism in QObject (C++ API), that keeps a stack per-object.
+
+        Since we do not support multiple threads, one static stack will be enough for
+        handling the behavior.
+
+        This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
+
+        * bridge/qt/qt_instance.cpp:
+        (JSC::Bindings::QtInstance::qtSenderStack):
+        We have one static stack of QObject*. The top of the stack contains the
+        last object that emitted signal that called a JavaScript function.
+
+        * bridge/qt/qt_instance.h:
+        (JSC::Bindings::QtInstance::QtSenderStack::top):
+        (JSC::Bindings::QtInstance::QtSenderStack::push):
+        (JSC::Bindings::QtInstance::QtSenderStack::pop):
+        Minimal functionality to manipulate the sender stack.
+
+        * bridge/qt/qt_runtime.cpp:
+        (JSC::Bindings::QtConnectionObject::execute):
+        Remove the previous code that modified the scope chain. Push the sender object
+        to the stack before calling the JavaScript function (the "slot" in Qt-speak) and
+        pop it afterwards.
+
 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/bridge/qt/qt_instance.cpp

@@ -45 +45 @@
 static QObjectInstanceMap cachedInstances;
 
+// Used for implementing '__qt_sender__'.
+Q_GLOBAL_STATIC(QtInstance::QtSenderStack, senderStack)
+
 // Derived RuntimeObject
 class QtRuntimeObject : public RuntimeObject {
@@ -322 +325 @@
 }
 
+QtInstance::QtSenderStack* QtInstance::qtSenderStack()
+{
+    return senderStack();
+}
+
 // In qt_runtime.cpp
 JSValue convertQVariantToValue(ExecState*, PassRefPtr<RootObject> root, const QVariant& variant);

trunk/Source/WebCore/bridge/qt/qt_instance.h

@@ -23 +23 @@
 #include "BridgeJSC.h"
 #include "runtime_root.h"
+#include <QStack>
 #include <QtScript/qscriptengine.h>
 #include <qhash.h>
@@ -72 +73 @@
     static QtInstance* getInstance(JSObject*);
 
+    class QtSenderStack {
+    public:
+        QObject* top() const { return m_stack.isEmpty() ? 0 : m_stack.top(); }
+        void push(QObject* object) { m_stack.push(object); }
+        void pop() { Q_ASSERT(!m_stack.isEmpty()); m_stack.pop(); }
+    private:
+        QStack<QObject*> m_stack;
+    };
+
+    // Used to implement '__qt_sender__'.
+    static QtSenderStack* qtSenderStack();
+
 private:
     static PassRefPtr<QtInstance> create(QObject *instance, PassRefPtr<RootObject> rootObject, QScriptEngine::ValueOwnership ownership)

trunk/Source/WebCore/bridge/qt/qt_runtime.cpp

@@ -1839 +1839 @@
                         }
                     }
-                    // Stuff in the __qt_sender property, if we can
-                    ScopeChainNode* oldsc = 0;
-                    JSFunction* fimp = 0;
-                    if (m_funcObject->inherits(&JSFunction::s_info)) {
-                        fimp = static_cast<JSFunction*>(m_funcObject.get());
-
-                        JSObject* qt_sender = QtInstance::getQtInstance(sender(), ro, QScriptEngine::QtOwnership)->createRuntimeObject(exec);
-                        JSObject* wrapper = constructEmptyObject(exec, createEmptyObjectStructure(exec->globalData(), jsNull()));
-                        PutPropertySlot slot;
-                        wrapper->put(exec, Identifier(exec, "__qt_sender__"), qt_sender, slot);
-                        oldsc = fimp->scope();
-                        fimp->setScope(exec->globalData(), oldsc->push(wrapper));
-                    }
+
+                    const bool withQtSenderStack = m_funcObject->inherits(&JSFunction::s_info);
+                    if (withQtSenderStack)
+                        QtInstance::qtSenderStack()->push(QObject::sender());
 
                     CallData callData;
@@ -1857 +1848 @@
                     call(exec, m_funcObject.get(), callType, callData, m_thisObject.get(), l);
 
-                    if (fimp)
-                        fimp->setScope(exec->globalData(), oldsc);
+                    if (withQtSenderStack)
+                        QtInstance::qtSenderStack()->pop();
                 }
             }

trunk/Source/WebKit/qt/Api/qwebframe.cpp

@@ -23 +23 @@
 
 #if USE(JSC)
+#include "APICast.h"
 #include "BridgeJSC.h"
 #include "CallFrame.h"
@@ -50 +51 @@
 #include "InspectorController.h"
 #if USE(JSC)
+#include "JavaScript.h"
 #include "JSDOMBinding.h"
 #include "JSDOMWindowBase.h"
 #include "JSLock.h"
 #include "JSObject.h"
+#include "JSRetainPtr.h"
+#include "OpaqueJSString.h"
 #elif USE(V8)
 #include "V8DOMWrapper.h"
@@ -472 +476 @@
 #endif
 }
+
+void QWebFramePrivate::didClearWindowObject()
+{
+#if USE(JSC)
+    if (page->settings()->testAttribute(QWebSettings::JavascriptEnabled))
+        addQtSenderToGlobalObject();
+#endif
+    emit q->javaScriptWindowObjectCleared();
+}
+
+#if USE(JSC)
+static JSValueRef qtSenderCallback(JSContextRef context, JSObjectRef, JSObjectRef, size_t, const JSValueRef[], JSValueRef*)
+{
+    QObject* sender = JSC::Bindings::QtInstance::qtSenderStack()->top();
+    if (!sender)
+        return JSValueMakeUndefined(context);
+
+    JSC::ExecState* exec = ::toJS(context);
+    RefPtr<JSC::Bindings::RootObject> rootObject = JSC::Bindings::findRootObject(exec->dynamicGlobalObject());
+    JSC::JSObject* jsSender = JSC::Bindings::QtInstance::getQtInstance(sender, rootObject, QScriptEngine::QtOwnership)->createRuntimeObject(exec);
+    return ::toRef(jsSender);
+}
+
+void QWebFramePrivate::addQtSenderToGlobalObject()
+{
+    JSC::JSLock lock(JSC::SilenceAssertionsOnly);
+
+    JSDOMWindow* window = toJSDOMWindow(frame, mainThreadNormalWorld());
+    Q_ASSERT(window);
+
+    JSC::ExecState* exec = window->globalExec();
+    Q_ASSERT(exec);
+
+    JSContextRef context = ::toRef(exec);
+    JSRetainPtr<JSStringRef> propertyName(Adopt, JSStringCreateWithUTF8CString("__qt_sender__"));
+    JSObjectRef function = JSObjectMakeFunctionWithCallback(context, propertyName.get(), qtSenderCallback);
+
+    // JSC public API doesn't support setting a Getter for a property of a given object, https://bugs.webkit.org/show_bug.cgi?id=61374.
+    window->defineGetter(exec, propertyName.get()->identifier(&exec->globalData()), ::toJS(function),
+                         JSC::ReadOnly | JSC::DontEnum | JSC::DontDelete);
+}
+#endif
+
 /*!
     \class QWebFrame

trunk/Source/WebKit/qt/Api/qwebframe_p.h

@@ -109 +109 @@
     void _q_orientationChanged();
 
+    void didClearWindowObject();
+
     QWebFrame *q;
     Qt::ScrollBarPolicy horizontalScrollBarPolicy;
@@ -127 +129 @@
 #if ENABLE(ORIENTATION_EVENTS) && ENABLE(DEVICE_ORIENTATION)
     QtMobility::QOrientationSensor m_orientation;
+#endif
+
+private:
+#if USE(JSC)
+    void addQtSenderToGlobalObject();
 #endif
 };

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2011-05-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
+        https://bugs.webkit.org/show_bug.cgi?id=61343
+
+        Create a '__qt_sender__' property in the global object, that returns the top of
+        the qtSenderStack. This is an alternative implementation for the feature of
+        providing a way for a function (acting as a Qt 'slot') discover which object
+        emitted the signal that caused it to be executed.
+
+        This reduces the coupling of the Qt bridge and JSC internal implementation. The
+        patch tries to use as much JSC public API as possible.
+
+        This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
+
+        * WebCoreSupport/FrameLoaderClientQt.cpp:
+        (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
+        Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls
+        a QWebPagePrivate function to do it.
+
+        * Api/qwebframe_p.h:
+        * Api/qwebframe.cpp:
+        (QWebFramePrivate::didClearedWindowObject):
+        Before emitting the signal mentioned, adds the '__qt_sender__' to the fresh
+        global object.
+
+        (qtSenderCallback):
+        Returns the JSObjectRef corresponding to the top of qtSenderStack.
+
+        (QWebFramePrivate::addQtSenderToGlobalObject):
+        Create a property with a qtSenderCallback as getter function in the global object.
+
 2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>
 

trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

@@ -764 +764 @@
 
     if (m_webFrame)
-        emit m_webFrame->javaScriptWindowObjectCleared();
+        m_webFrame->d->didClearWindowObject();
 }