Changeset 87338 in webkit


Ignore:
Timestamp:
May 25, 2011 5:24:04 PM (13 years ago)
Author:
adamk@chromium.org
Message:

2011-05-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r87333.
​http://trac.webkit.org/changeset/87333
​https://bugs.webkit.org/show_bug.cgi?id=61488

Breaks Chromium build due to pure virtual methods. (Requested
by aklein on #webkit).

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
Location:
trunk/Source/WebKit/chromium
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/chromium/ChangeLog

    r87333 r87338  
     12011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r87333.
     4        http://trac.webkit.org/changeset/87333
     5        https://bugs.webkit.org/show_bug.cgi?id=61488
     6
     7        Breaks Chromium build due to pure virtual methods. (Requested
     8        by aklein on #webkit).
     9
     10        * public/WebWidget.h:
     11        * src/WebPopupMenuImpl.cpp:
     12        * src/WebPopupMenuImpl.h:
     13        * src/WebViewImpl.cpp:
     14        * src/WebViewImpl.h:
     15
    1162011-05-25  Sailesh Agrawal  <sail@chromium.org>
    217

  • trunk/Source/WebKit/chromium/public/WebWidget.h

    r87333 r87338  
    5656    virtual WebSize size() = 0;
    5757
    58     // Used to group a series of resize events. For example, if the user
    59     // drags a resizer then willStartLiveResize will be called, followed by a
    60     // sequence of resize events, ending with willEndLiveResize when the user
    61     // lets go of the resizer.
    62     virtual void willStartLiveResize() = 0;
    63 
    6458    // Called to resize the WebWidget.
    6559    virtual void resize(const WebSize&) = 0;
    66 
    67     // Ends a group of resize events that was started with a call to
    68     // willStartLiveResize.
    69     virtual void willEndLiveResize() = 0;
    7060
    7161    // Called to update imperative animation state.  This should be called before

  • trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp

    r87333 r87338  
    137137}
    138138
    139 void WebPopupMenuImpl::willStartLiveResize()
    140 {
    141 }
    142 
    143139void WebPopupMenuImpl::resize(const WebSize& newSize)
    144140{
    … …  
    156152        m_client->didInvalidateRect(damagedRect);
    157153    }
    158 }
    159 
    160 void WebPopupMenuImpl::willEndLiveResize()
    161 {
    162154}
    163155

  • trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h

    r87333 r87338  
    6363    virtual void close();
    6464    virtual WebSize size() { return m_size; }
    65     virtual void willStartLiveResize();
    6665    virtual void resize(const WebSize&);
    67     virtual void willEndLiveResize();
    6866    virtual void animate();
    6967    virtual void layout();

  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r87337 r87338  
    973973}
    974974
    975 void WebViewImpl::willStartLiveResize()
    976 {
    977     if (mainFrameImpl() && mainFrameImpl()->frameView())
    978         mainFrameImpl()->frameView()->willStartLiveResize();
    979 }
    980 
    981975void WebViewImpl::resize(const WebSize& newSize)
    982976{
    … …  
    10071001    }
    10081002#endif
    1009 }
    1010 
    1011 void WebViewImpl::willEndLiveResize()
    1012 {
    1013     if (mainFrameImpl() && mainFrameImpl()->frameView())
    1014         mainFrameImpl()->frameView()->willEndLiveResize();
    10151003}
    10161004

  • trunk/Source/WebKit/chromium/src/WebViewImpl.h

    r87333 r87338  
    9292    virtual void close();
    9393    virtual WebSize size() { return m_size; }
    94     virtual void willStartLiveResize();
    9594    virtual void resize(const WebSize&);
    96     virtual void willEndLiveResize();
    9795    virtual void animate();
    9896    virtual void layout();
Note: See TracChangeset for help on using the changeset viewer.