Changeset 87378 in webkit

Timestamp:

May 26, 2011 5:48:19 AM (13 years ago)

Author:

Adam Roben

Message:

Correctly detect cases where only a single test failed/crashed/timed out

Fixes <​http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
failing test

Reviewed by Darin Adler.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
will be singular when only a single test fails/crashes/times out.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
failed/crashed/timed out.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js

@@ -126 +126 @@
 
             var failureCount = layoutTestStep.results[1].reduce(function(sum, outputLine) {
-                var match = /^(\d+) test cases/.exec(outputLine);
+                var match = /^(\d+) test case/.exec(outputLine);
                 if (!match)
                     return sum;

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js

@@ -105 +105 @@
                     item.appendChild(document.createTextNode(' (too many failures/crashes/timeouts)'));
                 else
-                    item.appendChild(document.createTextNode(' (' + buildInfo.failureCount + ' failing tests)'));
+                    item.appendChild(document.createTextNode(' (' + buildInfo.failureCount + ' failing test' + (buildInfo.failureCount > 1 ? 's' : '') + ')'));
                 list.appendChild(item);
             });

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-25  Adam Roben  <aroben@apple.com>
+
+        Correctly detect cases where only a single test failed/crashed/timed out
+
+        Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
+        failing test
+
+        Reviewed by Darin Adler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
+        (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
+        will be singular when only a single test fails/crashes/times out.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+        (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
+        failed/crashed/timed out.
+
 2011-05-26  Tom Hudson  <tomhudson@google.com>