Changeset 87517 in webkit

Timestamp:

May 27, 2011 9:14:39 AM (13 years ago)

Author:

Carlos Garcia Campos

Message:

2011-05-27 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
​https://bugs.webkit.org/show_bug.cgi?id=60757

cairo_image_surface_create_for_data() is already a shallow copy of
the image, so we don't need to copy it again.

• Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/cairo/ShareableBitmapCairo.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
+        https://bugs.webkit.org/show_bug.cgi?id=60757
+
+        cairo_image_surface_create_for_data() is already a shallow copy of
+        the image, so we don't need to copy it again.
+
+        * Shared/cairo/ShareableBitmapCairo.cpp:
+        (WebKit::ShareableBitmap::paint):
+
 2011-05-26  Jeff Miller  <jeffm@apple.com>
 

trunk/Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp

@@ -51 +51 @@
                                                                                    m_size.width(), m_size.height(),
                                                                                    m_size.width() * 4));
-
-    // This copy is not copy-on-write, so this is probably sub-optimal.
-    RefPtr<cairo_surface_t> surfaceCopy = copyCairoImageSurface(surface.get());
     FloatRect destRect(dstPoint, srcRect.size());
-    context.platformContext()->drawSurfaceToContext(surfaceCopy.get(), destRect, srcRect, &context);
+    context.platformContext()->drawSurfaceToContext(surface.get(), destRect, srcRect, &context);
 }