Changeset 87765 in webkit

Timestamp:

May 31, 2011 6:05:12 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-31 Raphael Kubo da Costa <​kubo@profusion.mobi>

Reviewed by Adam Barth.

[efl] Add ewk API to enable/disable developer extras.
​https://bugs.webkit.org/show_bug.cgi?id=61746

Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
to enable or disable developer extras (currently, the Web Inspector)
in a given view.

• ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_enable_developer_extras_get): (ewk_view_setting_enable_developer_extras_set):
• ewk/ewk_view.h:

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_view.cpp (modified) (3 diffs)
• ewk/ewk_view.h (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-05-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        Reviewed by Adam Barth.
+
+        [efl] Add ewk API to enable/disable developer extras.
+        https://bugs.webkit.org/show_bug.cgi?id=61746
+
+        Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
+        to enable or disable developer extras (currently, the Web Inspector)
+        in a given view.
+
+        * ewk/ewk_view.cpp:
+        (_ewk_view_priv_new):
+        (ewk_view_setting_enable_developer_extras_get):
+        (ewk_view_setting_enable_developer_extras_set):
+        * ewk/ewk_view.h:
+
 2011-05-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
 

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -113 +113 @@
         Eina_Bool auto_shrink_images:1;
         Eina_Bool enable_auto_resize_window:1;
+        Eina_Bool enable_developer_extras:1;
         Eina_Bool enable_scripts:1;
         Eina_Bool enable_plugins:1;
@@ -608 +609 @@
     priv->settings.auto_shrink_images = priv->page_settings->shrinksStandaloneImagesToFit();
     priv->settings.enable_auto_resize_window = EINA_TRUE;
+    priv->settings.enable_developer_extras = priv->page_settings->developerExtrasEnabled();
     priv->settings.enable_scripts = priv->page_settings->isJavaScriptEnabled();
     priv->settings.enable_plugins = priv->page_settings->arePluginsEnabled();
@@ -2679 +2681 @@
 }
 
+/**
+ * Returns whether developer extensions are enabled for the given view.
+ *
+ * Currently, this is used to know whether the Web Inspector is enabled for a
+ * given view.
+ *
+ * @param o view object to check.
+ *
+ * @return @c EINA_TRUE if developer extensions are enabled, @c EINA_FALSE
+ *         otherwise.
+ */
+Eina_Bool ewk_view_setting_enable_developer_extras_get(Evas_Object* o)
+{
+    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
+    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
+    return priv->settings.enable_developer_extras;
+}
+
+/**
+ * Enables/disables developer extensions for the given view.
+ *
+ * This currently controls whether the Web Inspector should be enabled.
+ *
+ * @param o The view whose setting will be changed.
+ * @param enable @c EINA_TRUE to enable developer extras, @c EINA_FALSE to
+ *               disable.
+ *
+ * @return @c EINA_TRUE on success, @EINA_FALSE on failure.
+ */
+Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable)
+{
+    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
+    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
+    enable = !!enable;
+    if (priv->settings.enable_developer_extras != enable) {
+        priv->page_settings->setDeveloperExtrasEnabled(enable);
+        priv->settings.enable_developer_extras = enable;
+    }
+    return EINA_TRUE;
+}
+
 int ewk_view_setting_font_minimum_size_get(const Evas_Object* o)
 {

trunk/Source/WebKit/efl/ewk/ewk_view.h

@@ -501 +501 @@
 EAPI Eina_Bool    ewk_view_setting_encoding_detector_set(Evas_Object* o, Eina_Bool enable);
 
+EAPI Eina_Bool    ewk_view_setting_enable_developer_extras_get(Evas_Object* o);
+EAPI Eina_Bool    ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable);
+
 /* to be used by subclass implementations */
 EAPI Ewk_View_Smart_Data *ewk_view_smart_data_get(const Evas_Object *o);