Changeset 87787 in webkit


Ignore:
Timestamp:
Jun 1, 2011 2:10:08 AM (13 years ago)
Author:
Nikolas Zimmermann
Message:

2011-06-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
​https://bugs.webkit.org/show_bug.cgi?id=15483

The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
it happened somewhen after executing this test, which is probably why it was flakey.

  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
  • svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
  • svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
  • svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.
Location:
trunk/LayoutTests
Files:
1 deleted
1 edited
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r87785 r87787  
     12011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>
     2
     3        Reviewed by Andreas Kling.
     4
     5        REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
     6        https://bugs.webkit.org/show_bug.cgi?id=15483
     7
     8        The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
     9        Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
     10        to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
     11        it happened somewhen after executing this test, which is probably why it was flakey.
     12
     13        * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
     14        * platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
     15        * svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
     16        * svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
     17        * svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.
     18
    1192011-06-01  Mario Sanchez Prada  <msanchez@igalia.com>
    220

  • trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh-expected.txt

    r87782 r87787  
    1 layer at (0,0) size 800x600
    2   RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x600
    4   RenderBlock {HTML} at (0,0) size 800x600
    5     RenderBody {BODY} at (8,8) size 784x584
    6       RenderBlock {DIV} at (0,0) size 784x18
    7         RenderText {#text} at (0,0) size 446x18
    8           text run at (0,0) width 446: "PASSED -- if you can refresh this page w/o crashing you have passed."
    9       RenderBlock {DIV} at (0,18) size 784x18
    10         RenderText {#text} at (0,0) size 299x18
    11           text run at (0,0) width 299: "http://bugs.webkit.org/show_bug.cgi?id=12310"
    12       RenderBlock {DIV} at (0,36) size 200x200
     1PASS
     2http://bugs.webkit.org/show_bug.cgi?id=12310
     3

  • trunk/LayoutTests/svg/as-image/svg-background-crash-on-refresh.html

    r87782 r87787  
    1 <div>PASSED -- if you can refresh this page w/o crashing you have passed.</div>
     1<html>
     2<body>
     3<div id="status">FAIL</div>
    24<div>http://bugs.webkit.org/show_bug.cgi?id=12310</div>
    3 <div style="width: 200px; height: 200px; background-image: url(resources/butterfly.svg)">
     5<div style="width: 200px; height: 200px; background-image: url(resources/butterfly.svg)"></div>
     6<script>
     7if (window.layoutTestController) {
     8    layoutTestController.dumpAsText();
     9    layoutTestController.waitUntilDone();
     10    gc = function() { window.GCController.collect() };
     11} else if (!window.gc)
     12    gc = function() { };
     13
     14window.onload = function() {
     15    if (location.hash != "#2") {
     16        if (location.hash)
     17            location.hash = "#" + (parseInt(location.hash.slice(1)) + 1).toString();
     18        else
     19            location.hash = "#1";
     20
     21        gc();
     22        setTimeout(function() { location.reload() }, 0);
     23    } else {
     24        document.getElementById('status').innerHTML = "PASS";
     25        if (window.layoutTestController)
     26            layoutTestController.notifyDone();
     27    }
     28}
     29</script>
     30</body>
     31</html>
Note: See TracChangeset for help on using the changeset viewer.