Changeset 87844 in webkit


Ignore:
Timestamp:
Jun 1, 2011 1:57:15 PM (13 years ago)
Author:
jer.noble@apple.com
Message:

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Page layout messed up after exiting full screen at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=61755

  • fullscreen/full-screen-zIndex-after-expected.txt: Added.
  • fullscreen/full-screen-zIndex-after.html: Added.
  • platform/mac/fullscreen/full-screen-zIndex-after-expected.png: Added.

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Page layout messed up after exiting full screen at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=61755
<rdar://problem/9525277>

Test: fullscreen/full-screen-zIndex-after.html

Fix the incomplete implementation of r87660. Make parameters to
setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
inconsistent..

  • dom/Document.cpp: (WebCore::Document::webkitWillExitFullScreenForElement):
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r87843 r87844  
     12011-06-01  Jer Noble  <jer.noble@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Page layout messed up after exiting full screen at Apple trailers page
     6        https://bugs.webkit.org/show_bug.cgi?id=61755
     7
     8        * fullscreen/full-screen-zIndex-after-expected.txt: Added.
     9        * fullscreen/full-screen-zIndex-after.html: Added.
     10        * platform/mac/fullscreen/full-screen-zIndex-after-expected.png: Added.
     11
    1122011-06-01  Adam Barth  <abarth@webkit.org>
    213
  • trunk/Source/WebCore/ChangeLog

    r87841 r87844  
     12011-06-01  Jer Noble  <jer.noble@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Page layout messed up after exiting full screen at Apple trailers page
     6        https://bugs.webkit.org/show_bug.cgi?id=61755
     7        <rdar://problem/9525277>
     8
     9        Test: fullscreen/full-screen-zIndex-after.html
     10
     11        Fix the incomplete implementation of r87660. Make parameters to
     12        setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
     13        in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
     14        inconsistent..
     15
     16        * dom/Document.cpp:
     17        (WebCore::Document::webkitWillExitFullScreenForElement):
     18
    1192011-06-01  Levi Weintraub  <leviw@chromium.org>
    220
  • trunk/Source/WebCore/dom/Document.cpp

    r87802 r87844  
    49254925void Document::webkitWillExitFullScreenForElement(Element*)
    49264926{
    4927     setContainsFullScreenElementRecursively(ownerElement(), false);
     4927    setContainsFullScreenElementRecursively(m_fullScreenElement->parentElement() ? m_fullScreenElement->parentElement() : ownerElement(), false);
    49284928   
    49294929    m_fullScreenElement->willStopBeingFullscreenElement();
Note: See TracChangeset for help on using the changeset viewer.