Changeset 87896 in webkit

Timestamp:

Jun 2, 2011 5:00:55 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-02 Naiem Shaik <​naiem.shaik@gmail.com>

Reviewed by Kent Tamura.

Fixing invalid value being returned for default checkbox and radio state
​https://bugs.webkit.org/show_bug.cgi?id=61674

As per ​http://www.w3.org/TR/html5/number-state.html#checkbox-state and
​http://www.w3.org/TR/html5/number-state.html#radio-button-state:
The value IDL attribute is in mode default/on:
If the element has a value attribute, it must return that attribute's
value; otherwise, it must return the string "on".
Currently default value is empty string;Default value of Radio button
and checkbox should be "on"
This works as per spec in IE9,Firefox and Opera

• fast/forms/checkbox-default-value-expected.txt: Added.
• fast/forms/checkbox-default-value.html: Added.
• fast/forms/radio-default-value-expected.txt: Added.
• fast/forms/radio-default-value.html: Added.

2011-06-02 Naiem Shaik <​naiem.shaik@gmail.com>

Reviewed by Kent Tamura.

Fixing invalid value being returned for default checkbox and radio state
​https://bugs.webkit.org/show_bug.cgi?id=61674

As per ​http://www.w3.org/TR/html5/number-state.html#checkbox-state and
​http://www.w3.org/TR/html5/number-state.html#radio-button-state:
The value IDL attribute is in mode default/on:
If the element has a value attribute, it must return that attribute's
value; otherwise, it must return the string "on".
Currently default value is empty string;Default value of Radio button
and checkbox should be "on".Changed fallbackValue function to return the same
This works as per spec in IE9,Firefox and Opera

Tests: fast/forms/checkbox-default-value.html

fast/forms/radio-default-value.html

• html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::fallbackValue):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/checkbox-default-value-expected.txt (added)
• LayoutTests/fast/forms/checkbox-default-value.html (added)
• LayoutTests/fast/forms/radio-default-value-expected.txt (added)
• LayoutTests/fast/forms/radio-default-value.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/BaseCheckableInputType.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-02  Naiem Shaik  <naiem.shaik@gmail.com>
+
+        Reviewed by Kent Tamura.
+
+        Fixing invalid value being returned for default checkbox and radio state
+        https://bugs.webkit.org/show_bug.cgi?id=61674
+
+        As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
+        http://www.w3.org/TR/html5/number-state.html#radio-button-state:
+        The value IDL attribute is in mode default/on:
+        If the element has a value attribute, it must return that attribute's
+        value; otherwise, it must return the string "on".
+        Currently default value is empty string;Default value of Radio button
+        and checkbox should be "on"
+        This works as per spec in IE9,Firefox and Opera
+
+        * fast/forms/checkbox-default-value-expected.txt: Added.
+        * fast/forms/checkbox-default-value.html: Added.
+        * fast/forms/radio-default-value-expected.txt: Added.
+        * fast/forms/radio-default-value.html: Added.
+
 2011-06-02  Mario Sanchez Prada  <msanchez@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-02  Naiem Shaik  <naiem.shaik@gmail.com>
+
+        Reviewed by Kent Tamura.
+        
+        Fixing invalid value being returned for default checkbox and radio state
+        https://bugs.webkit.org/show_bug.cgi?id=61674
+
+        As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
+        http://www.w3.org/TR/html5/number-state.html#radio-button-state:
+        The value IDL attribute is in mode default/on: 
+        If the element has a value attribute, it must return that attribute's 
+        value; otherwise, it must return the string "on".  
+        Currently default value is empty string;Default value of Radio button 
+        and checkbox should be "on".Changed fallbackValue function to return the same
+        This works as per spec in IE9,Firefox and Opera
+
+        Tests: fast/forms/checkbox-default-value.html
+               fast/forms/radio-default-value.html
+
+        * html/BaseCheckableInputType.cpp:
+        (WebCore::BaseCheckableInputType::fallbackValue):
+
 2011-06-02  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/html/BaseCheckableInputType.cpp

@@ -95 +95 @@
 String BaseCheckableInputType::fallbackValue()
 {
-    return element()->checked() ? "on" : "";
+    return "on";
 }