Changeset 88004 in webkit

Timestamp:

Jun 3, 2011 4:10:29 AM (13 years ago)

Author:

mario@webkit.org

Message:

2011-06-03 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
​https://bugs.webkit.org/show_bug.cgi?id=59737

Update the caret position to the anchor's position after scrolling.

This behavior is specific to the Gtk port and requested because of
accessibility needs, that's why it's implemented in AXObjectCache.

Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html

• accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the caret is updated to be in the anchor's position after scrolling.

2011-06-03 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
​https://bugs.webkit.org/show_bug.cgi?id=59737

New layout test for testing this GTK-specific feature.

• platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Added.
• platform/gtk/accessibility/caret-browsing-anchor-followed.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt (added)
• LayoutTests/platform/gtk/accessibility/caret-browsing-anchor-followed.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        Focus and caret position should be updated when same-page links are followed
+        https://bugs.webkit.org/show_bug.cgi?id=59737
+
+        New layout test for testing this GTK-specific feature.
+
+        * platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Added.
+        * platform/gtk/accessibility/caret-browsing-anchor-followed.html: Added.
+
 2011-06-03  Dominic Cooney  <dominicc@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        Focus and caret position should be updated when same-page links are followed
+        https://bugs.webkit.org/show_bug.cgi?id=59737
+
+        Update the caret position to the anchor's position after scrolling.
+
+        This behavior is specific to the Gtk port and requested because of
+        accessibility needs, that's why it's implemented in AXObjectCache.
+
+        Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html
+
+        * accessibility/gtk/AXObjectCacheAtk.cpp:
+        (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the
+        caret is updated to be in the anchor's position after scrolling.
+
 2011-06-03  Dominic Cooney  <dominicc@chromium.org>
 

trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp

@@ -24 +24 @@
 #include "AccessibilityObjectWrapperAtk.h"
 #include "Document.h"
+#include "Frame.h"
+#include "FrameSelection.h"
 #include "Element.h"
 #include "GOwnPtr.h"
 #include "Range.h"
 #include "SelectElement.h"
+#include "TextAffinity.h"
 #include "TextIterator.h"
+#include "htmlediting.h"
 
 namespace WebCore {
@@ -206 +210 @@
 }
 
-void AXObjectCache::handleScrolledToAnchor(const Node*)
-{
+void AXObjectCache::handleScrolledToAnchor(const Node* node)
+{
+    // Make sure the caret position is set to the anchor position, so
+    // further use of arrow keys work as expected.
+    Document* document = node->document();
+    if (!document)
+        return;
+
+    Frame* frame = document->frame();
+    if (!frame)
+        return;
+
+    FrameSelection* selection = frame->selection();
+    if (!selection)
+        return;
+
+    selection->moveTo(firstPositionInOrBeforeNode(const_cast<Node*>(node)), DOWNSTREAM);
 }