Changeset 88035 in webkit

Timestamp:

Jun 3, 2011 12:00:09 PM (13 years ago)

Author:

dpranke@chromium.org

Message:

2011-06-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: fix duplicate logging regression
​https://bugs.webkit.org/show_bug.cgi?id=61981

• Scripts/webkitpy/layout_tests/layout_package/printing.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/layout_package/printing.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-03  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        nrwt: fix duplicate logging regression
+        https://bugs.webkit.org/show_bug.cgi?id=61981
+
+        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
+
 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py

@@ -218 +218 @@
         self.switches = parse_print_options(options.print_options, options.verbose)
 
+        self._logging_handler = None
         if self._stream.isatty() and not options.verbose:
             self._update_interval_seconds = FAST_UPDATES_SECONDS
             self._meter = metered_stream.MeteredStream(self._stream)
-            self._logging_handler = _configure_logging(self._meter, options.verbose)
+            if configure_logging:
+                self._logging_handler = _configure_logging(self._meter, options.verbose)
         else:
-            self._logging_handler = _configure_logging(self._stream, options.verbose)
             self._update_interval_seconds = SLOW_UPDATES_SECONDS
+            if configure_logging:
+                self._logging_handler = _configure_logging(self._stream, options.verbose)
 
     def cleanup(self):