Changeset 88091 in webkit

Timestamp:

Jun 3, 2011 9:59:11 PM (13 years ago)

Author:

ap@apple.com

Message:

2011-06-03 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

ResourceHandleMac should always respond to an authentication challenge
​https://bugs.webkit.org/show_bug.cgi?id=61667

I don't know if this can actually happen in practice, so no new tests.

• platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Cancel authentication challenge if we don't have a client. We must always respond to the challenge to release the connection, and there is nothing else to do in this state anyway.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/ResourceHandleMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-03  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Darin Adler.
+
+        ResourceHandleMac should always respond to an authentication challenge
+        https://bugs.webkit.org/show_bug.cgi?id=61667
+
+        I don't know if this can actually happen in practice, so no new tests.
+
+        * platform/network/mac/ResourceHandleMac.mm:
+        (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
+        Cancel authentication challenge if we don't have a client. We must always respond to the
+        challenge to release the connection, and there is nothing else to do in this state anyway.
+
 2011-06-03  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm

@@ -748 +748 @@
     LOG(Network, "Handle %p delegate connection:%p didReceiveAuthenticationChallenge:%p", m_handle, connection, challenge);
 
-    if (!m_handle)
-        return;
+    if (!m_handle) {
+        [[challenge sender] cancelAuthenticationChallenge:challenge];
+        return;
+    }
     m_handle->didReceiveAuthenticationChallenge(core(challenge));
 }