Changeset 88109 in webkit

Timestamp:

Jun 4, 2011 4:14:49 AM (13 years ago)

Author:

thakis@chromium.org

Message:

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ChromePrintContext's destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62076

Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
that is dynamically set to either a ChromePrintContext or a
ChromePluginPrintContext, this fixes an actual bug.

• src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::~ChromePrintContext): (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebFrameImpl.cpp (modified) (2 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make ChromePrintContext's destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62076
+
+        Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
+        that is dynamically set to either a ChromePrintContext or a
+        ChromePluginPrintContext, this fixes an actual bug.
+
+        * src/WebFrameImpl.cpp:
+        (WebKit::ChromePrintContext::~ChromePrintContext):
+        (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
+
 2011-06-04  Nico Weber  <thakis@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

@@ -307 +307 @@
     }
 
+    virtual ~ChromePrintContext() { }
+
     virtual void begin(float width, float height)
     {
@@ -376 +378 @@
     {
     }
+
+    virtual ~ChromePluginPrintContext() { }
 
     virtual void begin(float width, float height)