Changeset 88212 in webkit


Ignore:
Timestamp:
Jun 6, 2011 9:04:25 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

CSS property outline not displayed on an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57439

  • fast/replaced/no-focus-ring-embed-1-expected.txt: Added.
  • fast/replaced/no-focus-ring-embed-1.html: Added.
  • fast/replaced/no-focus-ring-embed-2-expected.txt: Added.
  • fast/replaced/no-focus-ring-embed-2.html: Added.
  • fast/replaced/no-focus-ring-iframe-expected.txt: Added.
  • fast/replaced/no-focus-ring-iframe.html: Added.
  • fast/replaced/no-focus-ring-object-1-expected.txt: Added.
  • fast/replaced/no-focus-ring-object-1.html: Added.
  • fast/replaced/no-focus-ring-object-2-expected.txt: Added.
  • fast/replaced/no-focus-ring-object-2.html: Added.
  • fast/replaced/outline-replaced-elements-expected.txt: Added.
  • fast/replaced/outline-replaced-elements.html: Added.
  • fast/replaced/resources/focus-test.js: Added. (element.onfocus): Use a small delay to avoid test false positives.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added.

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

Draw CSS outline style for render widgets: iframe, embed, object, applet.
https://bugs.webkit.org/show_bug.cgi?id=57439

Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
be focused (via clicks or tabIndex) but should not have a visible focus ring by default.

Tests: fast/replaced/no-focus-ring-embed-1.html

fast/replaced/no-focus-ring-embed-2.html
fast/replaced/no-focus-ring-iframe.html
fast/replaced/no-focus-ring-object-1.html
fast/replaced/no-focus-ring-object-2.html
fast/replaced/outline-replaced-elements.html

  • css/html.css: (applet:focus, embed:focus, iframe:focus, object:focus): Default to no focus ring.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
Location:
trunk
Files:
14 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r88211 r88212  
     12011-06-06  Noel Gordon  <noel.gordon@gmail.com>
     2
     3        Reviewed by Hajime Morita.
     4
     5        CSS property outline not displayed on an iframe.
     6        https://bugs.webkit.org/show_bug.cgi?id=57439
     7
     8        * fast/replaced/no-focus-ring-embed-1-expected.txt: Added.
     9        * fast/replaced/no-focus-ring-embed-1.html: Added.
     10        * fast/replaced/no-focus-ring-embed-2-expected.txt: Added.
     11        * fast/replaced/no-focus-ring-embed-2.html: Added.
     12        * fast/replaced/no-focus-ring-iframe-expected.txt: Added.
     13        * fast/replaced/no-focus-ring-iframe.html: Added.
     14        * fast/replaced/no-focus-ring-object-1-expected.txt: Added.
     15        * fast/replaced/no-focus-ring-object-1.html: Added.
     16        * fast/replaced/no-focus-ring-object-2-expected.txt: Added.
     17        * fast/replaced/no-focus-ring-object-2.html: Added.
     18        * fast/replaced/outline-replaced-elements-expected.txt: Added.
     19        * fast/replaced/outline-replaced-elements.html: Added.
     20        * fast/replaced/resources/focus-test.js: Added.
     21        (element.onfocus): Use a small delay to avoid test false positives.
     22        * platform/chromium/test_expectations.txt:
     23        * platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added.
     24
    1252011-06-06  MORITA Hajime  <morrita@google.com>
    226
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r88206 r88212  
    22842284BUGCR54333 WIN LINUX : fast/replaced/embed-display-none.html = PASS TIMEOUT
    22852285BUGCR54348 LINUX : http/tests/security/xssAuditor/dom-write-innerHTML.html = PASS TEXT
     2286
     2287// Rebaseline WIN/LINUX image results when bug http://webkit.org/b/57439 rolls.
     2288BUGWK57439 WIN LINUX : fast/replaced/outline-replaced-elements.html = IMAGE+TEXT
    22862289
    22872290// WebKit r67068
  • trunk/Source/WebCore/ChangeLog

    r88211 r88212  
     12011-06-06  Noel Gordon  <noel.gordon@gmail.com>
     2
     3        Reviewed by Hajime Morita.
     4
     5        Draw CSS outline style for render widgets: iframe, embed, object, applet.
     6        https://bugs.webkit.org/show_bug.cgi?id=57439
     7
     8        Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
     9        be focused (via clicks or tabIndex) but should not have a visible focus ring by default.
     10
     11        Tests: fast/replaced/no-focus-ring-embed-1.html
     12               fast/replaced/no-focus-ring-embed-2.html
     13               fast/replaced/no-focus-ring-iframe.html
     14               fast/replaced/no-focus-ring-object-1.html
     15               fast/replaced/no-focus-ring-object-2.html
     16               fast/replaced/outline-replaced-elements.html
     17
     18        * css/html.css:
     19        (applet:focus, embed:focus, iframe:focus, object:focus):  Default to no focus ring.
     20        * rendering/RenderWidget.cpp:
     21        (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
     22
    1232011-06-06  MORITA Hajime  <morrita@google.com>
    224
  • trunk/Source/WebCore/css/html.css

    r88115 r88212  
    852852    outline: none
    853853}
     854
     855applet:focus, embed:focus, iframe:focus, object:focus {
     856    outline: none
     857}
    854858 
    855859input:focus, textarea:focus, isindex:focus, keygen:focus, select:focus {
  • trunk/Source/WebCore/rendering/RenderWidget.cpp

    r88200 r88212  
    264264    }
    265265
    266     if (!m_frameView || paintInfo.phase != PaintPhaseForeground || style()->visibility() != VISIBLE)
     266    if ((paintInfo.phase == PaintPhaseOutline || paintInfo.phase == PaintPhaseSelfOutline) && hasOutline())
     267        paintOutline(paintInfo.context, IntRect(tx, ty, width(), height()));
     268
     269    if (!m_frameView || paintInfo.phase != PaintPhaseForeground)
    267270        return;
    268271
Note: See TracChangeset for help on using the changeset viewer.