Changeset 88623 in webkit
- Timestamp:
- Jun 12, 2011 7:05:29 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r88622 r88623 1 2011-06-12 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Darin Adler. 4 5 DocumentParser::appendBytes should use size_t for length instead of int 6 https://bugs.webkit.org/show_bug.cgi?id=62508 7 8 size_t is the proper type for distances in memory, especially on 64 bit 9 machines. 10 11 * dom/DecodedDataDocumentParser.cpp: 12 (WebCore::DecodedDataDocumentParser::appendBytes): 13 * dom/DecodedDataDocumentParser.h: 14 * dom/DocumentParser.h: 15 * html/ImageDocument.cpp: 16 (WebCore::ImageDocumentParser::appendBytes): 17 * html/MediaDocument.cpp: 18 (WebCore::MediaDocumentParser::appendBytes): 19 * html/PluginDocument.cpp: 20 (WebCore::PluginDocumentParser::appendBytes): 21 * loader/SinkDocument.cpp: 22 (WebCore::SinkDocumentParser::appendBytes): 23 1 24 2011-06-12 Adam Barth <abarth@webkit.org> 2 25 -
trunk/Source/WebCore/dom/DecodedDataDocumentParser.cpp
r88609 r88623 38 38 } 39 39 40 void DecodedDataDocumentParser::appendBytes(DocumentWriter* writer, const char* data, int length)40 void DecodedDataDocumentParser::appendBytes(DocumentWriter* writer, const char* data, size_t length) 41 41 { 42 42 if (!length) -
trunk/Source/WebCore/dom/DecodedDataDocumentParser.h
r88609 r88623 45 45 46 46 // appendBytes and flush are used by DocumentWriter (the loader). 47 virtual void appendBytes(DocumentWriter*, const char* bytes, int length);47 virtual void appendBytes(DocumentWriter*, const char* bytes, size_t length); 48 48 virtual void flush(DocumentWriter*); 49 49 }; -
trunk/Source/WebCore/dom/DocumentParser.h
r88609 r88623 47 47 48 48 // appendBytes and flush are used by DocumentWriter (the loader). 49 virtual void appendBytes(DocumentWriter*, const char* bytes, int length) = 0;49 virtual void appendBytes(DocumentWriter*, const char* bytes, size_t length) = 0; 50 50 virtual void flush(DocumentWriter*) = 0; 51 51 -
trunk/Source/WebCore/html/ImageDocument.cpp
r88609 r88623 91 91 } 92 92 93 virtual void appendBytes(DocumentWriter*, const char*, int);93 virtual void appendBytes(DocumentWriter*, const char*, size_t); 94 94 virtual void finish(); 95 95 }; … … 125 125 } 126 126 127 void ImageDocumentParser::appendBytes(DocumentWriter*, const char*, int)127 void ImageDocumentParser::appendBytes(DocumentWriter*, const char*, size_t) 128 128 { 129 129 Frame* frame = document()->frame(); -
trunk/Source/WebCore/html/MediaDocument.cpp
r88609 r88623 61 61 } 62 62 63 virtual void appendBytes(DocumentWriter*, const char*, int);63 virtual void appendBytes(DocumentWriter*, const char*, size_t); 64 64 65 65 void createDocumentStructure(); … … 104 104 } 105 105 106 void MediaDocumentParser::appendBytes(DocumentWriter*, const char*, int)106 void MediaDocumentParser::appendBytes(DocumentWriter*, const char*, size_t) 107 107 { 108 108 if (m_mediaElement) -
trunk/Source/WebCore/html/PluginDocument.cpp
r88609 r88623 59 59 } 60 60 61 virtual void appendBytes(DocumentWriter*, const char*, int);61 virtual void appendBytes(DocumentWriter*, const char*, size_t); 62 62 63 63 void createDocumentStructure(); … … 104 104 } 105 105 106 void PluginDocumentParser::appendBytes(DocumentWriter*, const char*, int)106 void PluginDocumentParser::appendBytes(DocumentWriter*, const char*, size_t) 107 107 { 108 108 if (m_embedElement) -
trunk/Source/WebCore/loader/SinkDocument.cpp
r88609 r88623 45 45 46 46 // Ignore all data. 47 virtual void appendBytes(DocumentWriter*, const char*, int) { }47 virtual void appendBytes(DocumentWriter*, const char*, size_t) { } 48 48 }; 49 49
Note: See TracChangeset
for help on using the changeset viewer.