Changeset 88627 in webkit

Timestamp:

Jun 12, 2011 9:55:42 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-12 Hironori Bono <​hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
​https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

• editing/spelling/spellcheck-api-crash-expected.txt: Added.
• editing/spelling/spellcheck-api-crash.html: Added.

2011-06-12 Hironori Bono <​hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
​https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

Test: editing/spelling/spellcheck-api-crash.html

• html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange):
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange):
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/spelling/spellcheck-api-crash-expected.txt (added)
• LayoutTests/editing/spelling/spellcheck-api-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLDivElement.cpp (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (1 diff)
• Source/WebCore/html/HTMLTextAreaElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-12  Hironori Bono  <hbono@chromium.org>
+
+        Reviewed by Hajime Morita.
+
+        Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
+        https://bugs.webkit.org/show_bug.cgi?id=62526
+
+        This change adds null checks to the following function to prevent crashes
+        when calling removeSpellcheckRange() with null:
+        HTMLTextAreaElement::removeSpellcheckRange(),
+        HTMLInputElement::removeSpellcheckRange(), and
+        HTMLDivElement::removeSpellcheckRange().
+
+        * editing/spelling/spellcheck-api-crash-expected.txt: Added.
+        * editing/spelling/spellcheck-api-crash.html: Added.
+
 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-12  Hironori Bono  <hbono@chromium.org>
+
+        Reviewed by Hajime Morita.
+
+        Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
+        https://bugs.webkit.org/show_bug.cgi?id=62526
+
+        This change adds null checks to the following function to prevent crashes
+        when calling removeSpellcheckRange() with null:
+        HTMLTextAreaElement::removeSpellcheckRange(),
+        HTMLInputElement::removeSpellcheckRange(), and
+        HTMLDivElement::removeSpellcheckRange().
+
+        Test: editing/spelling/spellcheck-api-crash.html
+
+        * html/HTMLDivElement.cpp:
+        (WebCore::HTMLDivElement::removeSpellcheckRange):
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::removeSpellcheckRange):
+        * html/HTMLTextAreaElement.cpp:
+        (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
+
 2011-06-12  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/html/HTMLDivElement.cpp

@@ -96 +96 @@
 void HTMLDivElement::removeSpellcheckRange(RefPtr<SpellcheckRange> range)
 {
+    if (!range)
+        return;
     document()->markers()->removeUserSpellingMarker(this, range->start(), range->length());
 }

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -1862 +1862 @@
 void HTMLInputElement::removeSpellcheckRange(RefPtr<SpellcheckRange> range)
 {
+    if (!range)
+        return;
     document()->markers()->removeUserSpellingMarker(this, range->start(), range->length());
 }

trunk/Source/WebCore/html/HTMLTextAreaElement.cpp

@@ -463 +463 @@
 void HTMLTextAreaElement::removeSpellcheckRange(RefPtr<SpellcheckRange> range)
 {
+    if (!range)
+        return;
     document()->markers()->removeUserSpellingMarker(this, range->start(), range->length());
 }