Changeset 88639 in webkit

Timestamp:

Jun 13, 2011 8:09:59 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-13 KwangHyuk Kim <​hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
​https://bugs.webkit.org/show_bug.cgi?id=62448

Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter

• ewk/ewk_tiled_model.c: (ewk_tile_new):
• ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_tiled_model.c (modified) (1 diff)
• ewk/ewk_view_single.c (modified) (1 diff, 1 prop)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-06-13  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
+        https://bugs.webkit.org/show_bug.cgi?id=62448 
+ 
+        Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
+        from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter
+
+        * ewk/ewk_tiled_model.c:
+        (ewk_tile_new):
+        * ewk/ewk_view_single.c:
+        (_ewk_view_single_smart_repaints_process):
+
 2011-06-12  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebKit/efl/ewk/ewk_tiled_model.c

@@ -261 +261 @@
         bytes = area * 4;
         stride = w * 4;
-        format = CAIRO_FORMAT_RGB24;
+        format = CAIRO_FORMAT_ARGB32;
     } else if (cspace == EVAS_COLORSPACE_RGB565_A5P) {
         bytes = area * 2;

trunk/Source/WebKit/efl/ewk/ewk_view_single.c

@@ -392 +392 @@
     pixels = evas_object_image_data_get(sd->backing_store, 1);
     evas_object_image_size_get(sd->backing_store, &ow, &oh);
-
-    if (sd->bg_color.a < 255)
-        format = CAIRO_FORMAT_ARGB32;
-    else
-        format = CAIRO_FORMAT_RGB24;
+    format = CAIRO_FORMAT_ARGB32;
 
     surface = cairo_image_surface_create_for_data