Changeset 88640 in webkit
- Timestamp:
- Jun 13, 2011 8:28:56 AM (13 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r88638 r88640 1 2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com> 2 3 Reviewed by Kenneth Rohde Christiansen. 4 5 [EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl 6 https://bugs.webkit.org/show_bug.cgi?id=62429 7 8 * UIProcess/API/efl/PageClientImpl.cpp: 9 (WebKit::PageClientImpl::scrollView): 10 (WebKit::PageClientImpl::setCursor): 11 (WebKit::PageClientImpl::windowToScreen): 12 (WebKit::PageClientImpl::doneWithKeyEvent): 13 (WebKit::PageClientImpl::setFindIndicator): 14 (WebKit::PageClientImpl::didCommitLoadForMainFrame): 15 (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): 16 (WebKit::PageClientImpl::findStringInCustomRepresentation): 17 (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): 18 * UIProcess/API/efl/PageClientImpl.h: 19 1 20 2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com> 2 21 -
trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp
r88440 r88640 65 65 } 66 66 67 void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset)67 void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize&) 68 68 { 69 69 setViewNeedsDisplay(scrollRect); 70 #define USE_EWK_TOUCH 171 #if USE_EWK_TOUCH72 evas_object_move(m_viewObject, 0, 0);73 #endif74 70 } 75 71 … … 125 121 } 126 122 127 void PageClientImpl::setCursor(const Cursor& cursor)123 void PageClientImpl::setCursor(const Cursor&) 128 124 { 129 125 notImplemented(); … … 168 164 } 169 165 170 IntRect PageClientImpl::windowToScreen(const IntRect& rect)166 IntRect PageClientImpl::windowToScreen(const IntRect&) 171 167 { 172 168 notImplemented(); … … 174 170 } 175 171 176 void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled)172 void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool) 177 173 { 178 174 notImplemented(); … … 191 187 } 192 188 193 void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut)189 void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator>, bool) 194 190 { 195 191 notImplemented(); … … 201 197 } 202 198 203 void PageClientImpl::didCommitLoadForMainFrame(bool useCustomRepresentation)204 { 205 notImplemented(); 206 } 207 208 void PageClientImpl::didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&)199 void PageClientImpl::didCommitLoadForMainFrame(bool) 200 { 201 notImplemented(); 202 } 203 204 void PageClientImpl::didFinishLoadingDataForCustomRepresentation(const String&, const CoreIPC::DataReference&) 209 205 { 210 206 notImplemented(); … … 227 223 } 228 224 229 void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount)230 { 231 notImplemented(); 232 } 233 234 void PageClientImpl::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount)225 void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned) 226 { 227 notImplemented(); 228 } 229 230 void PageClientImpl::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned) 235 231 { 236 232 notImplemented(); -
trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.h
r88440 r88640 51 51 virtual void setViewNeedsDisplay(const WebCore::IntRect&); 52 52 virtual void displayView(); 53 virtual void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset);53 virtual void scrollView(const WebCore::IntRect&, const WebCore::IntSize&); 54 54 virtual WebCore::IntSize viewSize(); 55 55 virtual bool isViewWindowActive(); … … 75 75 virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&); 76 76 77 virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled);77 virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool); 78 78 79 79 virtual PassRefPtr<WebPopupMenuProxy> createPopupMenuProxy(WebPageProxy*); 80 80 virtual PassRefPtr<WebContextMenuProxy> createContextMenuProxy(WebPageProxy*); 81 81 82 virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut);82 virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool); 83 83 84 84 virtual void didChangeScrollbarsForMainFrame() const; 85 85 86 virtual void didCommitLoadForMainFrame(bool useCustomRepresentation);87 virtual void didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&);86 virtual void didCommitLoadForMainFrame(bool); 87 virtual void didFinishLoadingDataForCustomRepresentation(const String&, const CoreIPC::DataReference&); 88 88 virtual double customRepresentationZoomFactor(); 89 89 virtual void setCustomRepresentationZoomFactor(double); 90 90 91 virtual void flashBackingStoreUpdates(const Vector<WebCore::IntRect>& updateRects);92 virtual void findStringInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount);93 virtual void countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount);91 virtual void flashBackingStoreUpdates(const Vector<WebCore::IntRect>&); 92 virtual void findStringInCustomRepresentation(const String&, FindOptions, unsigned); 93 virtual void countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned); 94 94 95 95 virtual float userSpaceScaleFactor() const;
Note: See TracChangeset
for help on using the changeset viewer.