Changeset 88780 in webkit

Timestamp:

Jun 13, 2011 11:31:18 PM (13 years ago)

Author:

hayato@chromium.org

Message:

2011-06-13 Hayato Ito <​hayato@chromium.org>

Reviewed by Ojan Vafai.

[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
​https://bugs.webkit.org/show_bug.cgi?id=59188

A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
WebKitDriver should always return an actual hash value if DRT returns that.

No tests since I'll add sample reftests to make sure mismatch reftests work later,
which should be in a separate patch.

• Scripts/webkitpy/layout_tests/port/webkit.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/webkit.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-13  Hayato Ito  <hayato@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
+        https://bugs.webkit.org/show_bug.cgi?id=59188
+
+        A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
+        WebKitDriver should always return an actual hash value if DRT returns that.
+
+        No tests since I'll add sample reftests to make sure mismatch reftests work later,
+        which should be in a separate patch.
+
+        * Scripts/webkitpy/layout_tests/port/webkit.py:
+
 2011-06-13  Kent Tamura  <tkent@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py

@@ -442 +442 @@
                 image = block.decoded_content
                 actual_image_hash = block.content_hash
+            elif block.content_hash:
+                actual_image_hash = block.content_hash
 
         error_lines = self._server_process.error.splitlines()