Changeset 88920 in webkit


Ignore:
Timestamp:
Jun 15, 2011 5:09:18 AM (13 years ago)
Author:
apavlov@chromium.org
Message:

2011-06-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: "data" URLs not detected in CSS url(...) values properly
​https://bugs.webkit.org/show_bug.cgi?id=62643

WebCore:

  • inspector/front-end/inspector.js: (WebInspector.completeURL):

LayoutTests:

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r88919 r88920  
     12011-06-14  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Web Inspector: "data" URLs not detected in CSS url(...) values properly
     6        https://bugs.webkit.org/show_bug.cgi?id=62643
     7
     8        * inspector/styles/styles-url-linkify-expected.txt:
     9        * inspector/styles/styles-url-linkify.html:
     10
    1112011-06-15  Mario Sanchez Prada  <msanchez@igalia.com>
    212

  • trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt

    r78535 r88920  
    1 Tests that URLs are linked to and completed correctly. Bugs 51663, 53171
     1Tests that URLs are linked to and completed correctly. Bugs 51663, 53171, 62643
    22
    33
    4 Partial URLs completed:
     4URLs completed:
    55http://example.com/
    66http://example.com/moo
    … …  
    1313http://example.com/foo?a=b
    1414http://example.com/foo?a=b
     15data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEIAAABCAgMAAACeOuh7AAAABGdBTUEAAK/INwWK6QAAAAlQTFRF////AAAA////fu+PTwAAAAF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8AAAAASUVORK5CYII=
    1516Link for a URI from CSS document:
    1617inspector/styles/resources/fromcss.png

  • trunk/LayoutTests/inspector/styles/styles-url-linkify.html

    r88337 r88920  
    1414    }
    1515
    16     InspectorTest.addResult("Partial URLs completed:");
     16    InspectorTest.addResult("URLs completed:");
    1717    completeURL("http://example.com", "/");
    1818    completeURL("http://example.com", "moo");
    … …  
    2525    completeURL("http://example.com/foo", "?a=b");
    2626    completeURL("http://example.com/foo?c=d", "?a=b");
     27
     28    const dataURL = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEIAAABCAgMAAACeOuh7AAAABGdBTUEAAK/INwWK6QAAAAlQTFRF////AAAA////fu+PTwAAAAF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8AAAAASUVORK5CYII=";
     29    completeURL("https://example.com/foo", dataURL);
    2730
    2831    function dumpHref()
    … …  
    7174<body onload="runAfterIframeIsLoaded()">
    7275<p>
    73 Tests that URLs are linked to and completed correctly. Bugs <a href="http://bugs.webkit.org/show_bug.cgi?id=51663">51663</a>, <a href="http://bugs.webkit.org/show_bug.cgi?id=53171">53171</a>
     76Tests that URLs are linked to and completed correctly. Bugs <a href="http://bugs.webkit.org/show_bug.cgi?id=51663">51663</a>, <a href="http://bugs.webkit.org/show_bug.cgi?id=53171">53171</a>, <a href="http://bugs.webkit.org/show_bug.cgi?id=62643">62643</a>
    7477</p>
    7578<div id="local"></div>

  • trunk/Source/WebCore/ChangeLog

    r88918 r88920  
     12011-06-14  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Web Inspector: "data" URLs not detected in CSS url(...) values properly
     6        https://bugs.webkit.org/show_bug.cgi?id=62643
     7
     8        * inspector/front-end/inspector.js:
     9        (WebInspector.completeURL):
     10
    1112011-06-15  Pavel Feldman  <pfeldman@google.com>
    212

  • trunk/Source/WebCore/inspector/front-end/inspector.js

    r88815 r88920  
    13191319        // Return absolute URLs as-is.
    13201320        var parsedHref = href.asParsedURL();
    1321         if (parsedHref && parsedHref.scheme)
     1321        if ((parsedHref && parsedHref.scheme) || href.indexOf("data:") === 0)
    13221322            return href;
    13231323    }
Note: See TracChangeset for help on using the changeset viewer.