Changeset 88928 in webkit


Ignore:
Timestamp:
Jun 15, 2011 7:38:14 AM (13 years ago)
Author:
demarchi@webkit.org
Message:

2011-06-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r88723.
​http://trac.webkit.org/changeset/88723
​https://bugs.webkit.org/show_bug.cgi?id=62726

Stack can be empty, so it needs to be checked before as
pointed out in the comments of the bug. (Requested by demarchi
on #webkit).

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::registerCommandForRedo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canRedo): (WebCore::EditorClientEfl::redo):
  • WebCoreSupport/EditorClientEfl.h:
Location:
trunk/Source/WebKit/efl
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/efl/ChangeLog

    r88725 r88928  
     12011-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r88723.
     4        http://trac.webkit.org/changeset/88723
     5        https://bugs.webkit.org/show_bug.cgi?id=62726
     6
     7        Stack can be empty, so it needs to be checked before as
     8        pointed out in the comments of the bug. (Requested by demarchi
     9        on #webkit).
     10
     11        * WebCoreSupport/EditorClientEfl.cpp:
     12        (WebCore::EditorClientEfl::registerCommandForUndo):
     13        (WebCore::EditorClientEfl::registerCommandForRedo):
     14        (WebCore::EditorClientEfl::clearUndoRedoOperations):
     15        (WebCore::EditorClientEfl::canRedo):
     16        (WebCore::EditorClientEfl::redo):
     17        * WebCoreSupport/EditorClientEfl.h:
     18
    1192011-06-13  Michal Pakula vel Rutka  <m.pakula@samsung.com>
    220

  • trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp

    r88723 r88928  
    148148void EditorClientEfl::registerCommandForUndo(WTF::PassRefPtr<EditCommand> command)
    149149{
    150     redoStack.clear();
    151150    undoStack.append(command);
    152151}
    153152
    154 void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtr<EditCommand> command)
    155 {
    156     redoStack.append(command);
     153void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtr<EditCommand>)
     154{
     155    notImplemented();
    157156}
    158157
    … …  
    160159{
    161160    undoStack.clear();
    162     redoStack.clear();
    163161}
    164162
    … …  
    180178bool EditorClientEfl::canRedo() const
    181179{
    182     return !redoStack.isEmpty();
     180    notImplemented();
     181    return false;
    183182}
    184183
    … …  
    192191void EditorClientEfl::redo()
    193192{
    194     RefPtr<WebCore::EditCommand> command(*(--redoStack.end()));
    195     redoStack.remove(--redoStack.end());
    196     command->reapply();
     193    notImplemented();
    197194}
    198195

  • trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h

    r88723 r88928  
    4848protected:
    4949    WTF::Deque<WTF::RefPtr<WebCore::EditCommand> > undoStack;
    50     WTF::Deque<WTF::RefPtr<WebCore::EditCommand> > redoStack;
    5150
    5251public:
Note: See TracChangeset for help on using the changeset viewer.