Changeset 88934 in webkit
- Timestamp:
- Jun 15, 2011 8:09:29 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 10 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r88931 r88934 1 2011-06-15 Noel Gordon <noel.gordon@gmail.com> 2 3 Reviewed by Eric Seidel. 4 5 CSS property outline not displayed on an iframe. 6 https://bugs.webkit.org/show_bug.cgi?id=57439 7 8 * fast/replaced/no-focus-ring-embed-expected.txt: Added. 9 * fast/replaced/no-focus-ring-embed.html: Added. 10 * fast/replaced/no-focus-ring-iframe-expected.txt: Added. 11 * fast/replaced/no-focus-ring-iframe.html: Added. 12 * fast/replaced/no-focus-ring-object-expected.txt: Added. 13 * fast/replaced/no-focus-ring-object.html: Added. 14 * fast/replaced/outline-replaced-elements-expected.txt: Added. 15 * fast/replaced/outline-replaced-elements.html: Added. 16 * fast/replaced/resources/focus-test.js: Added. 17 (element.onfocus): Use a small delay to avoid test false positives. 18 * platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added. 19 1 20 2011-06-15 Sheriff Bot <webkit.review.bot@gmail.com> 2 21 -
trunk/Source/WebCore/ChangeLog
r88932 r88934 1 2011-06-15 Noel Gordon <noel.gordon@gmail.com> 2 3 Reviewed by Eric Seidel. 4 5 Draw CSS outline style for render widgets: iframe, embed, object, applet. 6 https://bugs.webkit.org/show_bug.cgi?id=57439 7 8 Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can 9 be focused (via clicks or tabIndex) but should not have a visible focus ring by default. 10 11 Tests: fast/replaced/no-focus-ring-embed.html 12 fast/replaced/no-focus-ring-iframe.html 13 fast/replaced/no-focus-ring-object.html 14 fast/replaced/outline-replaced-elements.html 15 16 * css/html.css: 17 (applet:focus, embed:focus, iframe:focus, object:focus): Default to no focus ring. 18 * rendering/RenderWidget.cpp: 19 (WebCore::RenderWidget::paint): Paint the render widget CSS outline style. 20 1 21 2011-06-15 Steve Block <steveblock@google.com> 2 22 -
trunk/Source/WebCore/css/html.css
r88757 r88934 869 869 outline: none 870 870 } 871 872 applet:focus, embed:focus, iframe:focus, object:focus { 873 outline: none 874 } 871 875 872 876 input:focus, textarea:focus, isindex:focus, keygen:focus, select:focus { -
trunk/Source/WebCore/rendering/RenderWidget.cpp
r88319 r88934 263 263 } 264 264 265 if (!m_frameView || paintInfo.phase != PaintPhaseForeground || style()->visibility() != VISIBLE) 265 if ((paintInfo.phase == PaintPhaseOutline || paintInfo.phase == PaintPhaseSelfOutline) && hasOutline()) 266 paintOutline(paintInfo.context, IntRect(adjustedPaintOffset, size())); 267 268 if (!m_frameView || paintInfo.phase != PaintPhaseForeground) 266 269 return; 267 270
Note: See TracChangeset
for help on using the changeset viewer.