Changeset 88985 in webkit

Timestamp:

Jun 15, 2011 5:37:01 PM (13 years ago)

Author:

gyuyoung.kim@samsung.com

Message:

2011-06-15 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Implement animationXXX functions for Progress Tag
​https://bugs.webkit.org/show_bug.cgi?id=62713

Progress tag need to implement acnimationXXX functions in order to show animation of
progress tag. Because, RenderProgress decides to show update progress bar's animation
according to the functions.

• platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeEfl::animationDurationForProgressBar):
• platform/efl/RenderThemeEfl.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/efl/RenderThemeEfl.cpp (modified) (2 diffs)
• platform/efl/RenderThemeEfl.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Reviewed by Kent Tamura.
+
+        [EFL] Implement animationXXX functions for Progress Tag
+        https://bugs.webkit.org/show_bug.cgi?id=62713
+
+        Progress tag need to implement acnimationXXX functions in order to show animation of 
+        progress tag. Because, RenderProgress decides to show update progress bar's animation
+        according to the functions.
+
+        * platform/efl/RenderThemeEfl.cpp:
+        (WebCore::RenderThemeEfl::animationRepeatIntervalForProgressBar):
+        (WebCore::RenderThemeEfl::animationDurationForProgressBar):
+        * platform/efl/RenderThemeEfl.h:
+
 2011-06-15  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp

@@ -62 +62 @@
 // TODO: as objects are webpage/user defined and they can be very large.
 #define RENDER_THEME_EFL_PART_CACHE_MAX 32
-    
+
+// Constants for progress tag animation.
+// These values have been copied from RenderThemeGtk.cpp
+static const int progressAnimationFrames = 10;
+static const double progressAnimationInterval = 0.125;
+
 static const int sliderThumbWidth = 12;
 static const int sliderThumbHeight = 12;
-
 #if ENABLE(VIDEO)
 static const int mediaSliderHeight = 14;
@@ -1093 +1097 @@
 }
 
+double RenderThemeEfl::animationRepeatIntervalForProgressBar(RenderProgress*) const
+{
+    return progressAnimationInterval;
+}
+
+double RenderThemeEfl::animationDurationForProgressBar(RenderProgress*) const
+{
+    return progressAnimationInterval * progressAnimationFrames * 2; // "2" for back and forth;
+}
+
 bool RenderThemeEfl::paintProgressBar(RenderObject* object, const PaintInfo& info, const IntRect& rect)
 {

trunk/Source/WebCore/platform/efl/RenderThemeEfl.h

@@ -167 +167 @@
     virtual void adjustProgressBarStyle(CSSStyleSelector*, RenderStyle*, Element*) const;
     virtual bool paintProgressBar(RenderObject*, const PaintInfo&, const IntRect&);
+    virtual double animationRepeatIntervalForProgressBar(RenderProgress*) const;
+    virtual double animationDurationForProgressBar(RenderProgress*) const;
 #endif