Changeset 89065 in webkit

Timestamp:

Jun 16, 2011 2:18:35 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-16 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Mihai Parparita.

[Chromium] Overlay scrollbars leave glitches on web content
​https://bugs.webkit.org/show_bug.cgi?id=62383

Enable overlay scrollbars on Chromium Mac.

• platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: (preferredScrollerStyle):

2011-06-16 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Mihai Parparita.

[Chromium] Overlay scrollbars leave glitches on web content
​https://bugs.webkit.org/show_bug.cgi?id=62383

Fix glitches when scrolling with overlay scrollbars. The problem was that the render widget was copying the scrollbars when scrolling. Fix was to intersect the clip rect with the scroll rect. This is the same thing that Safari does (see WebChromeClient::scroll).

• src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scroll):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/ChromeClientImpl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-16  Sailesh Agrawal  <sail@chromium.org>
+
+        Reviewed by Mihai Parparita.
+
+        [Chromium] Overlay scrollbars leave glitches on web content
+        https://bugs.webkit.org/show_bug.cgi?id=62383
+
+        Enable overlay scrollbars on Chromium Mac.
+
+        * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+        (preferredScrollerStyle):
+
 2011-06-16  una sabovic  <una.sabovic@palm.com>
 

trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm

@@ -125 +125 @@
 static NSScrollerStyle preferredScrollerStyle()
 {
-    // TODO(sail): Disable overlay scrollbars for now until the following issues are fixed:
-    // #1: Invalidation issues causes the scrollbar to leave trailing artifacts.
-    // #2: Find tick marks need to be drawn on the scrollbar track.
-    return NSScrollerStyleLegacy;
-
     if ([NSScroller respondsToSelector:@selector(preferredScrollerStyle)])
         return [NSScroller preferredScrollerStyle];

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-06-16  Sailesh Agrawal  <sail@chromium.org>
+
+        Reviewed by Mihai Parparita.
+
+        [Chromium] Overlay scrollbars leave glitches on web content
+        https://bugs.webkit.org/show_bug.cgi?id=62383
+
+        Fix glitches when scrolling with overlay scrollbars. The problem was that the render widget was copying the scrollbars when scrolling. Fix was to intersect the clip rect with the scroll rect. This is the same thing that Safari does (see WebChromeClient::scroll).
+
+        * src/ChromeClientImpl.cpp:
+        (WebKit::ChromeClientImpl::scroll):
+
 2011-06-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp

@@ -556 +556 @@
             int dx = scrollDelta.width();
             int dy = scrollDelta.height();
-            m_webView->client()->didScrollRect(dx, dy, clipRect);
+            m_webView->client()->didScrollRect(dx, dy, intersection(scrollRect, clipRect));
         }
 #if USE(ACCELERATED_COMPOSITING)