Changeset 89202 in webkit

Timestamp:

Jun 18, 2011 1:10:14 PM (13 years ago)

Author:

evan@chromium.org

Message:

2011-06-18 Evan Martin <​evan@chromium.org>

Reviewed by Darin Adler.

Compiler warning in double->int conversion in TestNetscapePlugIn
​https://bugs.webkit.org/show_bug.cgi?id=51554

This code is providing a JS API for removing a property by numeric ID.
We get it from JS as a double, and must convert it to an int before using it.

Test: LayoutTests/plugins/npruntime/remove-property.html

• DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: (NPRuntimeRemoveProperty::TestObject::invoke):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-18  Evan Martin  <evan@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Compiler warning in double->int conversion in TestNetscapePlugIn
+        https://bugs.webkit.org/show_bug.cgi?id=51554
+
+        This code is providing a JS API for removing a property by numeric ID.
+        We get it from JS as a double, and must convert it to an int before using it.
+
+        Test: LayoutTests/plugins/npruntime/remove-property.html
+
+        * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
+        (NPRuntimeRemoveProperty::TestObject::invoke):
+
 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp

@@ -64 +64 @@
                 propertyName = pluginTest()->NPN_GetStringIdentifier(propertyNameString.c_str());
             } else {
-                int32_t number = arguments[1].value.doubleValue;
+                int32_t number = static_cast<int32_t>(arguments[1].value.doubleValue);
                 propertyName = pluginTest()->NPN_GetIntIdentifier(number);
             }