Changeset 89313 in webkit


Ignore:
Timestamp:
Jun 20, 2011 4:44:19 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-20 Tim Horton <​timothy_horton@apple.com>

Reviewed by Darin Adler.

Incorrect clamping on SVG masks when root element is not located at (0,0)
​https://bugs.webkit.org/show_bug.cgi?id=63019

  • platform/mac/svg/custom/absolute-root-position-masking-expected.png: Added.
  • platform/mac/svg/custom/absolute-root-position-masking-expected.txt: Added.
  • platform/qt/svg/custom/absolute-root-position-masking-expected.png: Added.
  • platform/qt/svg/custom/absolute-root-position-masking-expected.txt: Added.
  • svg/custom/absolute-root-position-masking.xhtml: Added.

2011-06-20 Tim Horton <​timothy_horton@apple.com>

Reviewed by Darin Adler.

Incorrect clamping on SVG masks when root element is not located at (0,0)
​https://bugs.webkit.org/show_bug.cgi?id=63019

We should be using frameRect(), not contentBoxRect() for the rect to
clamp to when creating an SVG mask image.

Test: svg/custom/absolute-root-position-masking.xhtml

  • rendering/svg/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::clampedAbsoluteTargetRectForRenderer):
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r89311 r89313  
     12011-06-20  Tim Horton  <timothy_horton@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Incorrect clamping on SVG masks when root element is not located at (0,0)
     6        https://bugs.webkit.org/show_bug.cgi?id=63019
     7
     8        * platform/mac/svg/custom/absolute-root-position-masking-expected.png: Added.
     9        * platform/mac/svg/custom/absolute-root-position-masking-expected.txt: Added.
     10        * platform/qt/svg/custom/absolute-root-position-masking-expected.png: Added.
     11        * platform/qt/svg/custom/absolute-root-position-masking-expected.txt: Added.
     12        * svg/custom/absolute-root-position-masking.xhtml: Added.
     13
    1142011-06-20  Kenneth Russell  <kbr@google.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r89312 r89313  
     12011-06-20  Tim Horton  <timothy_horton@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Incorrect clamping on SVG masks when root element is not located at (0,0)
     6        https://bugs.webkit.org/show_bug.cgi?id=63019
     7
     8        We should be using frameRect(), not contentBoxRect() for the rect to
     9        clamp to when creating an SVG mask image.
     10
     11        Test: svg/custom/absolute-root-position-masking.xhtml
     12
     13        * rendering/svg/SVGImageBufferTools.cpp:
     14        (WebCore::SVGImageBufferTools::clampedAbsoluteTargetRectForRenderer):
     15
    1162011-06-20  Adam Barth  <abarth@webkit.org>
    217

  • trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp

    r88250 r89313  
    120120    const RenderSVGRoot* svgRoot = SVGRenderSupport::findTreeRootObject(renderer);
    121121    FloatRect clampedAbsoluteTargetRect = absoluteTargetRect;
    122     clampedAbsoluteTargetRect.intersect(svgRoot->contentBoxRect());
     122    clampedAbsoluteTargetRect.intersect(svgRoot->frameRect());
    123123    return clampedAbsoluteTargetRect;
    124124}
Note: See TracChangeset for help on using the changeset viewer.