Changeset 89318 in webkit

Timestamp:

Jun 20, 2011 5:04:23 PM (13 years ago)

Author:

tonikitoo@webkit.org

Message:

2011-06-20 Antonio Gomes <​agomes@rim.com>

Reviewed by Ryosuke Niwa.

Stop adding empty rects in FrameSelection::getClippedVisibleTextRectangles
​https://bugs.webkit.org/show_bug.cgi?id=63018

No new tests needed, since it causes no behavioral change.

• editing/FrameSelection.cpp: (WebCore::FrameSelection::getClippedVisibleTextRectangles):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/FrameSelection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-20  Antonio Gomes  <agomes@rim.com>
+
+        Reviewed by Ryosuke Niwa.
+
+        Stop adding empty rects in FrameSelection::getClippedVisibleTextRectangles
+        https://bugs.webkit.org/show_bug.cgi?id=63018
+
+        No new tests needed, since it causes no behavioral change.
+
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::getClippedVisibleTextRectangles):
+
 2011-06-20  Joseph Pecoraro  <joepeck@webkit.org>
 

trunk/Source/WebCore/editing/FrameSelection.cpp

@@ -1789 +1789 @@
     toNormalizedRange()->textQuads(quads, true);
 
-    // FIXME: We are appending empty rectangles to the list for those that fall outside visibleContentRect.
-    // It might be better to omit those rectangles entirely.
     size_t size = quads.size();
-    for (size_t i = 0; i < size; ++i)
-        rectangles.append(intersection(quads[i].enclosingBoundingBox(), visibleContentRect));
+    for (size_t i = 0; i < size; ++i) {
+        FloatRect intersectionRect = intersection(quads[i].enclosingBoundingBox(), visibleContentRect);
+        if (!intersectionRect.isEmpty())
+            rectangles.append(intersectionRect);
+    }
 }