Changeset 89489 in webkit


Ignore:
Timestamp:
Jun 22, 2011 3:35:38 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-22 Cary Clark <​caryclark@google.com>

Reviewed by Darin Fisher.

Use Skia if Skia on Mac Chrome is enabled
​https://bugs.webkit.org/show_bug.cgi?id=62999

  • wtf/Platform.h: Add switch to use Skia if, externally, Skia has been enabled by a gyp define.

2011-06-22 Cary Clark <​caryclark@google.com>

Reviewed by Darin Fisher.

Use Skia if Skia on Mac Chrome is enabled
​https://bugs.webkit.org/show_bug.cgi?id=62999

No new tests. This does not affect existing
functionality.

  • WebCore.gyp/WebCore.gyp: Include Skia and related files and exclude CG and related files when building Chromium for Skia on the Mac.
  • loader/cache/CachedFont.cpp: Rename CHROME to CHROMIUM.
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Ditto.

2011-06-22 Cary Clark <​caryclark@google.com>

Reviewed by Darin Fisher.

Use Skia if Skia on Mac Chrome is enabled
​https://bugs.webkit.org/show_bug.cgi?id=62999

  • WebKit.gyp: If building for Skia, exclude CG files. If not, exclude Skia files.
  • features.gypi: Enable Skia on Chromium Mac if so instructed by the gyp define. Allow Skia to be hardware accelerated on the Mac.
  • public/WebCommon.h: If Skia is defined on the Mac, define it in the WebXXX interfaces as well.
Location:
trunk/Source
Files:
27 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r89472 r89489  
     12011-06-22  Cary Clark  <caryclark@google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Use Skia if Skia on Mac Chrome is enabled
     6        https://bugs.webkit.org/show_bug.cgi?id=62999
     7
     8        * wtf/Platform.h:
     9        Add switch to use Skia if, externally,
     10        Skia has been enabled by a gyp define.
     11
    1122011-06-22  Geoffrey Garen  <ggaren@apple.com>
    213

  • trunk/Source/JavaScriptCore/wtf/Platform.h

    r89311 r89489  
    544544#endif
    545545
    546 /* USE(SKIA) for Win/Linux, CG for Mac */
     546/* USE(SKIA) for Win/Linux, CG for Mac, unless enabled */
    547547#if PLATFORM(CHROMIUM)
    548548#if OS(DARWIN)
     549#if USE(SKIA_ON_MAC_CHROMIUM)
     550#define WTF_USE_SKIA 1
     551#else
    549552#define WTF_USE_CG 1
     553#endif
    550554#define WTF_USE_ATSUI 1
    551555#define WTF_USE_CORE_TEXT 1

  • trunk/Source/WebCore/ChangeLog

    r89479 r89489  
     12011-06-22  Cary Clark  <caryclark@google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Use Skia if Skia on Mac Chrome is enabled
     6        https://bugs.webkit.org/show_bug.cgi?id=62999
     7
     8        No new tests. This does not affect existing
     9        functionality.
     10
     11        * WebCore.gyp/WebCore.gyp:
     12        Include Skia and related files and exclude CG
     13        and related files when building Chromium for Skia
     14        on the Mac.
     15
     16        * loader/cache/CachedFont.cpp:
     17        Rename CHROME to CHROMIUM.
     18
     19        * platform/chromium/DragImageRef.h:
     20        * platform/graphics/FloatPoint.h:
     21        * platform/graphics/FloatRect.h:
     22        * platform/graphics/FloatSize.h:
     23        * platform/graphics/FontPlatformData.h:
     24        (WebCore::FontPlatformData::hash):
     25        * platform/graphics/GlyphBuffer.h:
     26        (WebCore::GlyphBuffer::advanceAt):
     27        (WebCore::GlyphBuffer::add):
     28        (WebCore::GlyphBuffer::expandLastAdvance):
     29        * platform/graphics/IntPoint.h:
     30        * platform/graphics/IntRect.h:
     31        * platform/graphics/IntSize.h:
     32        * platform/graphics/SimpleFontData.h:
     33        * platform/graphics/cg/FloatPointCG.cpp:
     34        * platform/graphics/cg/FloatRectCG.cpp:
     35        * platform/graphics/cg/FloatSizeCG.cpp:
     36        * platform/graphics/cg/IntPointCG.cpp:
     37        * platform/graphics/cg/IntRectCG.cpp:
     38        * platform/graphics/cg/IntSizeCG.cpp:
     39        * platform/graphics/mac/FontCustomPlatformData.cpp:
     40        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
     41        (WebCore::createFontCustomPlatformData):
     42        * platform/graphics/mac/FontCustomPlatformData.h:
     43        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
     44        Ditto.
     45
    1462011-06-22  Mark Pilgrim  <pilgrim@chromium.org>
    247

  • trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

    r89362 r89489  
    261261        ],
    262262      }],
    263       ['OS=="mac"', {
     263      ['OS=="mac" and use_skia==0', {
    264264        'webcore_include_dirs+': [
    265265          # platform/graphics/cg and cocoa need to come before
    … …  
    272272          '../platform/graphics/cg',
    273273        ],
     274      }],
     275      ['OS=="mac"', {
    274276        'webcore_include_dirs': [
    275277          # FIXME: Eliminate dependency on platform/mac and related
    … …  
    283285          '../platform/mac',
    284286          '../platform/text/mac',
     287        ],
     288      }],
     289      ['OS=="mac" and use_skia==1', {
     290        'webcore_include_dirs': [
     291              '../platform/graphics/cocoa',
     292              '../platform/graphics/cg',
    285293        ],
    286294      }],
    … …  
    13321340          ],
    13331341        }],
    1334         ['OS=="mac"', {
     1342        ['OS=="mac" and use_skia==0', {
     1343          'sources/': [
     1344            # The Mac build is PLATFORM_CG too.  platform/graphics/cg is the
     1345            # only place that CG files we want to build are located, and not
     1346            # all of them even have a CG suffix, so just add them by a
     1347            # regexp matching their directory.
     1348            ['include', 'platform/graphics/cg/[^/]*(?<!Win)?\\.(cpp|mm?)$'],
     1349          ],
     1350        }],['OS=="mac"', {
    13351351          # Necessary for Mac .mm stuff.
    13361352          'include_dirs': [
    … …  
    13621378            ['exclude', 'network/cf/'],
    13631379
    1364             # The Mac build is PLATFORM_CG too.  platform/graphics/cg is the
    1365             # only place that CG files we want to build are located, and not
    1366             # all of them even have a CG suffix, so just add them by a
    1367             # regexp matching their directory.
    1368             ['include', 'platform/graphics/cg/[^/]*(?<!Win)?\\.(cpp|mm?)$'],
    1369 
    13701380            # Use native Mac font code from WebCore.
    13711381            ['include', 'platform/(graphics/)?mac/[^/]*Font[^/]*\\.(cpp|mm?)$'],
    … …  
    13841394            ['include', 'platform/graphics/mac/FloatSizeMac\\.mm$'],
    13851395            ['include', 'platform/graphics/mac/GlyphPageTreeNodeMac\\.cpp$'],
    1386             ['include', 'platform/graphics/mac/GraphicsContextMac\\.mm$'],
    13871396            ['include', 'platform/graphics/mac/IntPointMac\\.mm$'],
    13881397            ['include', 'platform/graphics/mac/IntRectMac\\.mm$'],
    … …  
    14001409            ['include', 'WebKit/mac/WebCoreSupport/WebSystemInterface\\.mm$'],
    14011410
    1402             # Chromium Mac does not use skia.
    1403             ['exclude', 'platform/graphics/skia/[^/]*Skia\\.(cpp|h)$'],
    1404 
    14051411            # The Mac uses platform/mac/KillRingMac.mm instead of the dummy
    14061412            # implementation.
    … …  
    14141420            # related to ScrollbarThemeChromium.cpp.
    14151421            ['exclude', 'platform/chromium/ScrollbarThemeChromium\\.cpp$'],
    1416 
    1417             # The Mac currently uses ImageChromiumMac.mm from
    1418             # platform/graphics/chromium, included by regex above, instead.
    1419             ['exclude', 'platform/graphics/chromium/ImageChromium\\.cpp$'],
    14201422
    14211423            # The Mac does not use ImageSourceCG.cpp from platform/graphics/cg
    … …  
    14241426            ['exclude', 'platform/graphics/cg/PDFDocumentImage\\.cpp$'],
    14251427
    1426             # ImageDecoderSkia is not used on mac.  ImageDecoderCG is used instead.
    1427             ['exclude', 'platform/image-decoders/skia/ImageDecoderSkia\\.cpp$'],
    1428             ['include', 'platform/image-decoders/cg/ImageDecoderCG\\.cpp$'],
    1429 
    1430             # Again, Skia is not used on Mac.
    1431             ['exclude', 'platform/chromium/DragImageChromiumSkia\\.cpp$'],
     1428            ['include', '/chrome/junk\\.txt$'],
    14321429          ],
    14331430        },{ # OS!="mac"
    … …  
    14361433            # only used on mac.
    14371434            ['exclude', 'platform/graphics/FontPlatformData\\.cpp$'],
    1438 
    1439             # Linux uses FontLinux; Windows uses FontWin. Additionally, FontSkia
    1440             # is excluded by a rule above if WebKit uses CG instead of Skia.
    1441             ['exclude', 'platform/graphics/skia/FontSkia\\.cpp$'],
     1435          ],
     1436        }],
     1437        ['OS=="mac" and use_skia==0', {
     1438          'sources/': [
     1439            # Cherry-pick some files that can't be included by broader regexps.
     1440            # Some of these are used instead of Chromium platform files, see
     1441            # the specific exclusions in the "sources!" list below.
     1442            ['include', 'platform/graphics/mac/GraphicsContextMac\\.mm$'],
     1443
     1444            # Chromium Mac does not use skia.
     1445            ['exclude', 'platform/graphics/skia/[^/]*Skia\\.(cpp|h)$'],
     1446
     1447            # The Mac currently uses ImageChromiumMac.mm from
     1448            # platform/graphics/chromium, included by regex above, instead.
     1449            ['exclude', 'platform/graphics/chromium/ImageChromium\\.cpp$'],
     1450
     1451            # ImageDecoderSkia is not used on mac.  ImageDecoderCG is used instead.
     1452            ['exclude', 'platform/image-decoders/skia/ImageDecoderSkia\\.cpp$'],
     1453            ['include', 'platform/image-decoders/cg/ImageDecoderCG\\.cpp$'],
     1454
     1455            # Again, Skia is not used on Mac.
     1456            ['exclude', 'platform/chromium/DragImageChromiumSkia\\.cpp$'],
     1457          ],
     1458        }],
     1459        ['OS=="mac" and use_skia==1', {
     1460          'sources/': [
     1461            ['include', 'platform/graphics/cg/FloatPointCG\\.cpp$'],
     1462            ['include', 'platform/graphics/cg/FloatRectCG\\.cpp$'],
     1463            ['include', 'platform/graphics/cg/FloatSizeCG\\.cpp$'],
     1464            ['include', 'platform/graphics/cg/IntPointCG\\.cpp$'],
     1465            ['include', 'platform/graphics/cg/IntRectCG\\.cpp$'],
     1466            ['include', 'platform/graphics/cg/IntSizeCG\\.cpp$'],
     1467            ['exclude', 'platform/graphics/mac/FontMac\\.mm$'],
     1468            ['exclude', 'platform/graphics/skia/GlyphPageTreeNodeSkia\\.cpp$'],
     1469            ['exclude', 'platform/chromium/DragImageChromiumMac\\.cpp$'],
    14421470          ],
    14431471        }],
    … …  
    14461474            ['exclude', '(Gtk|Linux)\\.cpp$'],
    14471475            ['exclude', 'Harfbuzz[^/]+\\.(cpp|h)$'],
     1476          ],
     1477        }],
     1478        ['toolkit_uses_gtk == 0 and use_skia==0', {
     1479          'sources/': [
    14481480            ['exclude', 'VDMX[^/]+\\.(cpp|h)$'],
    14491481          ],
    14501482        }],
    14511483        ['OS!="mac"', {
    1452           'sources/': [['exclude', 'Mac\\.(cpp|mm?)$']]
     1484          'sources/': [
     1485            ['exclude', 'Mac\\.(cpp|mm?)$'],
     1486
     1487            # Linux uses FontLinux; Windows uses FontWin. Additionally, FontSkia
     1488            # is excluded by a rule above if WebKit uses CG instead of Skia.
     1489            ['exclude', 'platform/graphics/skia/FontSkia\\.cpp$'],
     1490          ],
    14531491        }],
    14541492        ['OS!="win"', {

  • trunk/Source/WebCore/loader/cache/CachedFont.cpp

    r88173 r89489  
    2929
    3030// FIXME: This should really be a blacklist instead of a whitelist
    31 #if USE(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && (!OS(DARWIN) || USE(SKIA_ON_MAC_CHROME))) || PLATFORM(HAIKU) || OS(WINCE) || PLATFORM(ANDROID) || PLATFORM(BREWMP)
     31#if USE(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && (!OS(DARWIN) || USE(SKIA_ON_MAC_CHROMIUM))) || PLATFORM(HAIKU) || OS(WINCE) || PLATFORM(ANDROID) || PLATFORM(BREWMP)
    3232#define STORE_FONT_CUSTOM_PLATFORM_DATA
    3333#endif

  • trunk/Source/WebCore/platform/chromium/DragImageRef.h

    r87821 r89489  
    3030#define DragImageRef_h
    3131
    32 #if OS(DARWIN) && !USE(SKIA_ON_MAC_CHROME)
     32#if USE(CG)
    3333typedef struct CGImage* CGImageRef;
    3434#else
    … …  
    3838namespace WebCore {
    3939
    40 #if OS(DARWIN) && !USE(SKIA_ON_MAC_CHROME)
     40#if USE(CG)
    4141typedef CGImageRef DragImageRef;
    4242#else

  • trunk/Source/WebCore/platform/graphics/FloatPoint.h

    r88264 r89489  
    3232#include <wtf/MathExtras.h>
    3333
    34 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     34#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3535typedef struct CGPoint CGPoint;
    3636#endif
    … …  
    126126    }   
    127127
    128 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     128#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    129129    FloatPoint(const CGPoint&);
    130130    operator CGPoint() const;

  • trunk/Source/WebCore/platform/graphics/FloatRect.h

    r89431 r89489  
    3030#include "FloatPoint.h"
    3131
    32 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     32#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3333typedef struct CGRect CGRect;
    3434#endif
    … …  
    140140    void fitToPoints(const FloatPoint& p0, const FloatPoint& p1, const FloatPoint& p2, const FloatPoint& p3);
    141141
    142 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     142#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    143143    FloatRect(const CGRect&);
    144144    operator CGRect() const;

  • trunk/Source/WebCore/platform/graphics/FloatSize.h

    r87312 r89489  
    3232#include <wtf/MathExtras.h>
    3333
    34 #if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROME)
     34#if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
    3535typedef struct CGSize CGSize;
    3636#endif
    … …  
    9292    }
    9393
    94 #if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROME)
     94#if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
    9595    explicit FloatSize(const CGSize&); // don't do this implicitly since it's lossy
    9696    operator CGSize() const;

  • trunk/Source/WebCore/platform/graphics/FontPlatformData.h

    r85507 r89489  
    8383#endif
    8484
    85 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     85#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    8686typedef struct CGFont* CGFontRef;
    8787#if OS(DARWIN)
    … …  
    177177    FontPlatformData(NSFont*, float size, bool syntheticBold = false, bool syntheticOblique = false, FontOrientation = Horizontal,
    178178                     TextOrientation = TextOrientationVerticalRight, FontWidthVariant = RegularWidth);
    179 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     179#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    180180    FontPlatformData(CGFontRef cgFont, float size, bool syntheticBold, bool syntheticOblique, FontOrientation orientation,
    181181                     TextOrientation textOrientation, FontWidthVariant widthVariant)
    … …  
    213213#endif
    214214
    215 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     215#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    216216#if OS(DARWIN)
    217217    CGFontRef cgFont() const { return m_cgFont.get(); }
    … …  
    246246        return m_font ? m_font->hash() : 0;
    247247#elif OS(DARWIN)
    248 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     248#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    249249        ASSERT(m_font || !m_cgFont);
    250250#endif
    … …  
    322322#endif
    323323
    324 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     324#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    325325#if PLATFORM(WIN)
    326326    RetainPtr<CGFontRef> m_cgFont;

  • trunk/Source/WebCore/platform/graphics/GlyphBuffer.h

    r85902 r89489  
    3636#include <wtf/Vector.h>
    3737
    38 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     38#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3939#include <CoreGraphics/CGGeometry.h>
    4040#endif
    … …  
    6363// CG uses CGSize instead of FloatSize so that the result of advances()
    6464// can be passed directly to CGContextShowGlyphsWithAdvances in FontMac.mm
    65 #if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROME)
     65#if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
    6666typedef CGSize GlyphBufferAdvance;
    6767#elif OS(WINCE)
    … …  
    127127    float advanceAt(int index) const
    128128    {
    129 #if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROME)
     129#if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
    130130        return m_advances[index].width;
    131131#elif OS(WINCE)
    … …  
    158158#endif
    159159
    160 #if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROME)
     160#if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
    161161        CGSize advance = { width, 0 };
    162162        m_advances.append(advance);
    … …  
    197197        ASSERT(!isEmpty());
    198198        GlyphBufferAdvance& lastAdvance = m_advances.last();
    199 #if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROME)
     199#if USE(CG) || (PLATFORM(WX) && OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
    200200        lastAdvance.width += width;
    201201#elif OS(WINCE)

  • trunk/Source/WebCore/platform/graphics/IntPoint.h

    r88451 r89489  
    3434#endif
    3535
    36 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     36#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3737typedef struct CGPoint CGPoint;
    3838#endif
    … …  
    122122    }
    123123
    124 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     124#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    125125    explicit IntPoint(const CGPoint&); // don't do this implicitly since it's lossy
    126126    operator CGPoint() const;

  • trunk/Source/WebCore/platform/graphics/IntRect.h

    r89133 r89489  
    3030#include <wtf/Vector.h>
    3131
    32 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     32#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3333typedef struct CGRect CGRect;
    3434#endif
    … …  
    203203#endif
    204204
    205 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     205#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    206206    operator CGRect() const;
    207207#endif
    … …  
    249249}
    250250
    251 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     251#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    252252IntRect enclosingIntRect(const CGRect&);
    253253#endif

  • trunk/Source/WebCore/platform/graphics/IntSize.h

    r87312 r89489  
    2727#define IntSize_h
    2828
    29 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     29#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3030typedef struct CGSize CGSize;
    3131#endif
    … …  
    110110    }
    111111
    112 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     112#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    113113    explicit IntSize(const CGSize&); // don't do this implicitly since it's lossy
    114114    operator CGSize() const;

  • trunk/Source/WebCore/platform/graphics/SimpleFontData.h

    r89311 r89489  
    133133    void setSpaceWidth(float spaceWidth) { m_spaceWidth = spaceWidth; }
    134134
    135 #if USE(CG) || USE(CAIRO) || PLATFORM(WX) || USE(SKIA_ON_MAC_CHROME)
     135#if USE(CG) || USE(CAIRO) || PLATFORM(WX) || USE(SKIA_ON_MAC_CHROMIUM)
    136136    float syntheticBoldOffset() const { return m_syntheticBoldOffset; }
    137137#endif
    … …  
    265265    mutable OwnPtr<DerivedFontData> m_derivedFontData;
    266266
    267 #if USE(CG) || USE(CAIRO) || PLATFORM(WX) || USE(SKIA_ON_MAC_CHROME)
     267#if USE(CG) || USE(CAIRO) || PLATFORM(WX) || USE(SKIA_ON_MAC_CHROMIUM)
    268268    float m_syntheticBoldOffset;
    269269#endif

  • trunk/Source/WebCore/platform/graphics/cg/FloatPointCG.cpp

    r84101 r89489  
    2828#include "FloatPoint.h"
    2929
    30 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     30#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3131
    3232#include <ApplicationServices/ApplicationServices.h>

  • trunk/Source/WebCore/platform/graphics/cg/FloatRectCG.cpp

    r84101 r89489  
    2828#include "FloatRect.h"
    2929
    30 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     30#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3131
    3232#include <ApplicationServices/ApplicationServices.h>

  • trunk/Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp

    r87312 r89489  
    2828#include "FloatSize.h"
    2929
    30 #if USE(CG) || USE(SKIA_ON_MAC_CHROME) || (PLATFORM(QT) && USE(QTKIT))
     30#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM) || (PLATFORM(QT) && USE(QTKIT))
    3131
    3232#include <ApplicationServices/ApplicationServices.h>

  • trunk/Source/WebCore/platform/graphics/cg/IntPointCG.cpp

    r84101 r89489  
    2727#include "IntPoint.h"
    2828
    29 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     29#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3030
    3131#include <ApplicationServices/ApplicationServices.h>

  • trunk/Source/WebCore/platform/graphics/cg/IntRectCG.cpp

    r87312 r89489  
    2727#include "IntRect.h"
    2828
    29 #if USE(CG) || USE(SKIA_ON_MAC_CHROME) || (PLATFORM(QT) && USE(QTKIT))
     29#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM) || (PLATFORM(QT) && USE(QTKIT))
    3030
    3131#include <ApplicationServices/ApplicationServices.h>

  • trunk/Source/WebCore/platform/graphics/cg/IntSizeCG.cpp

    r84101 r89489  
    2727#include "IntSize.h"
    2828
    29 #if USE(CG) || USE(SKIA_ON_MAC_CHROME)
     29#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
    3030
    3131#include <ApplicationServices/ApplicationServices.h>

  • trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp

    r88081 r89489  
    2828#include <ApplicationServices/ApplicationServices.h>
    2929
    30 #if USE(SKIA_ON_MAC_CHROME)
     30#if USE(SKIA_ON_MAC_CHROMIUM)
    3131#include "SkStream.h"
    3232#include "SkTypeface.h"
    … …  
    3535namespace WebCore {
    3636
    37 #if USE(SKIA_ON_MAC_CHROME)
     37#if USE(SKIA_ON_MAC_CHROMIUM)
    3838class RemoteFontStream : public SkStream {
    3939public:
    … …  
    8383        ATSFontDeactivate(m_atsContainer, NULL, kATSOptionFlagsDefault);
    8484#endif
    85 #if USE(SKIA_ON_MAC_CHROME)
     85#if USE(SKIA_ON_MAC_CHROMIUM)
    8686    SkSafeUnref(m_typeface);
    8787#endif
    … …  
    161161
    162162    FontCustomPlatformData* fontCustomPlatformData = new FontCustomPlatformData(containerRef, cgFontRef.releaseRef());
    163 #if USE(SKIA_ON_MAC_CHROME)
     163#if USE(SKIA_ON_MAC_CHROMIUM)
    164164    RemoteFontStream* stream = new RemoteFontStream(buffer);
    165165    fontCustomPlatformData->m_typeface = SkTypeface::CreateFromStream(stream);

  • trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h

    r88081 r89489  
    3434typedef UInt32 ATSFontRef;
    3535
    36 #if USE(SKIA_ON_MAC_CHROME)
     36#if USE(SKIA_ON_MAC_CHROMIUM)
    3737struct SkTypeface;
    3838#endif
    … …  
    4949        : m_atsContainer(container)
    5050        , m_cgFont(cgFont)
    51 #if USE(SKIA_ON_MAC_CHROME)
     51#if USE(SKIA_ON_MAC_CHROMIUM)
    5252        , m_typeface(0)
    5353#endif
    … …  
    6363    ATSFontContainerRef m_atsContainer;
    6464    CGFontRef m_cgFont;
    65 #if USE(SKIA_ON_MAC_CHROME)
     65#if USE(SKIA_ON_MAC_CHROMIUM)
    6666    SkTypeface* m_typeface;
    6767#endif

  • trunk/Source/WebKit/chromium/ChangeLog

    r89452 r89489  
     12011-06-22  Cary Clark  <caryclark@google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Use Skia if Skia on Mac Chrome is enabled
     6        https://bugs.webkit.org/show_bug.cgi?id=62999
     7
     8        * WebKit.gyp:
     9        If building for Skia, exclude CG files.
     10        If not, exclude Skia files.
     11
     12        * features.gypi:
     13        Enable Skia on Chromium Mac if so instructed by the gyp define.
     14        Allow Skia to be hardware accelerated on the Mac.
     15
     16        * public/WebCommon.h:
     17        If Skia is defined on the Mac, define it in the WebXXX
     18        interfaces as well.
     19
    1202011-06-22  Adam Barth  <abarth@webkit.org>
    221

  • trunk/Source/WebKit/chromium/WebKit.gyp

    r89089 r89489  
    685685                        'public/mac',
    686686                    ],
    687                     'sources/': [
    688                         ['exclude', 'Skia\\.cpp$'],
     687                    'conditions': [
     688                        ['use_skia==0', {
     689                            'sources/': [
     690                                ['exclude', 'Skia\\.cpp$'],
     691                            ],
     692                        },{ # use_skia
     693                            'sources/': [
     694                                ['exclude', 'CG\\.cpp$'],
     695                            ],
     696                        }],
    689697                    ],
    690698                }, { # else: OS!="mac"

  • trunk/Source/WebKit/chromium/features.gypi

    r89452 r89489  
    106106      'enable_touch_events%': 1,
    107107      'use_skia_gpu%': 0,
     108      'use_skia%': 0,
    108109      'enable_touch_icon_loading%' : 0,
    109110      'enable_smooth_scrolling%': 0,
    … …  
    122123        ],
    123124      }],
    124       ['use_accelerated_compositing==1 and OS!="mac"', {
     125      ['use_accelerated_compositing==1 and (OS!="mac" or use_skia==1)', {
    125126        'feature_defines': [
    126127          'ENABLE_ACCELERATED_2D_CANVAS=1',
    … …  
    148149          'WTF_USE_WEBAUDIO_FFMPEG=1',
    149150        ],
     151        'use_skia%': 1,
    150152      }],
    151153      ['enable_register_protocol_handler==1', {
    152154        'feature_defines': [
    153155          'ENABLE_REGISTER_PROTOCOL_HANDLER=1',
     156        ],
     157      }],
     158      ['OS=="mac"', {
     159        'feature_defines': [
     160          'WTF_USE_SKIA_ON_MAC_CHROMIUM=<(use_skia)',
    154161        ],
    155162      }],

  • trunk/Source/WebKit/chromium/public/WebCommon.h

    r87728 r89489  
    4040
    4141#if !defined(WEBKIT_USING_SKIA)
    42     #if !defined(__APPLE__)
     42    #if !defined(__APPLE__) || defined(USE_SKIA)
    4343        #define WEBKIT_USING_SKIA 1
    4444    #else
Note: See TracChangeset for help on using the changeset viewer.