Changeset 89789 in webkit
- Timestamp:
- Jun 26, 2011 11:49:16 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r89787 r89789 1 2011-06-26 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 Remove LegacyDefaultOptionalArguments from WebAudio IDL files 6 https://bugs.webkit.org/show_bug.cgi?id=63416 7 8 WebAudio isn't that widely used, so it's seems somewhat safe to remove 9 legacy code generation hacks. I'm not an expert on WebAudio, but the 10 API doesn't appear to need many optional arguments. 11 12 There are a bunch of APIs that have custom bindings that look like they 13 could be autogenerated. I've added FIXME comments where appropriate. 14 15 * webaudio/AudioBuffer.idl: 16 * webaudio/AudioContext.idl: 17 * webaudio/AudioListener.idl: 18 * webaudio/AudioNode.idl: 19 * webaudio/AudioPannerNode.idl: 20 * webaudio/AudioParam.idl: 21 * webaudio/RealtimeAnalyserNode.idl: 22 1 23 2011-06-26 Yury Semikhatsky <yurys@chromium.org> 2 24 -
trunk/Source/WebCore/webaudio/AudioBuffer.idl
r89148 r89789 29 29 module audio { 30 30 interface [ 31 LegacyDefaultOptionalArguments,32 31 Conditional=WEB_AUDIO 33 32 ] AudioBuffer { -
trunk/Source/WebCore/webaudio/AudioContext.idl
r89478 r89789 26 26 module webaudio { 27 27 interface [ 28 LegacyDefaultOptionalArguments,29 28 Conditional=WEB_AUDIO, 30 29 ActiveDOMObject, … … 49 48 readonly attribute AudioListener listener; 50 49 50 // FIXME: Switch from [Custom] to using IDL overloads. 51 51 // AudioBuffer createBuffer(in unsigned long numberOfChannels, in unsigned long numberOfFrames, in float sampleRate); 52 52 // AudioBuffer createBuffer(in ArrayBuffer buffer, in boolean mixToMono); 53 53 [Custom] AudioBuffer createBuffer() 54 54 raises(DOMException); 55 55 56 56 // Asynchronous audio file data decoding. 57 57 void decodeAudioData(in ArrayBuffer audioData, in [Callback] AudioBufferCallback successCallback, in [Optional, Callback] AudioBufferCallback errorCallback) … … 76 76 AudioChannelSplitter createChannelSplitter(); 77 77 AudioChannelMerger createChannelMerger(); 78 78 79 79 // Offline rendering 80 80 // void prepareOfflineBufferRendering(in unsigned long numberOfChannels, in unsigned long numberOfFrames, in float sampleRate); 81 81 attribute EventListener oncomplete; 82 82 void startRendering(); 83 84 83 }; 85 84 } -
trunk/Source/WebCore/webaudio/AudioListener.idl
r89148 r89789 29 29 module audio { 30 30 interface [ 31 LegacyDefaultOptionalArguments,32 31 Conditional=WEB_AUDIO 33 32 ] AudioListener { -
trunk/Source/WebCore/webaudio/AudioNode.idl
r89148 r89789 25 25 module audio { 26 26 interface [ 27 LegacyDefaultOptionalArguments,28 27 Conditional=WEB_AUDIO 29 28 ] AudioNode { … … 32 31 readonly attribute unsigned long numberOfOutputs; 33 32 34 [Custom] void connect(in AudioNode destination, in unsigned long output, in unsigned long input) 33 // FIXME: Why does this method need to be Custom? 34 [Custom] void connect(in AudioNode destination, in [Optional] unsigned long output, in [Optional] unsigned long input) 35 35 raises(DOMException); 36 36 37 [Custom] void disconnect(in unsigned long output) 37 // FIXME: Why does this method need to be Custom? 38 [Custom] void disconnect(in [Optional] unsigned long output) 38 39 raises(DOMException); 39 40 }; -
trunk/Source/WebCore/webaudio/AudioPannerNode.idl
r89148 r89789 25 25 module audio { 26 26 interface [ 27 LegacyDefaultOptionalArguments,28 27 Conditional=WEB_AUDIO, 29 28 GenerateConstructor, -
trunk/Source/WebCore/webaudio/AudioParam.idl
r89148 r89789 29 29 module webaudio { 30 30 interface [ 31 LegacyDefaultOptionalArguments,32 31 Conditional=WEB_AUDIO 33 32 ] AudioParam { … … 36 35 readonly attribute float maxValue; 37 36 readonly attribute float defaultValue; 38 37 39 38 readonly attribute DOMString name; 40 39 41 40 // FIXME: Could define units constants here (seconds, decibels, cents, etc.)... 42 41 readonly attribute unsigned short units; 43 42 44 43 // Parameter automation. 45 44 void setValueAtTime(in float value, in float time); … … 53 52 // The number of values will be scaled to fit into the desired duration. 54 53 void setValueCurveAtTime(in Float32Array values, in float time, in float duration); 55 54 56 55 // Cancels all scheduled parameter changes with times greater than or equal to startTime. 57 56 void cancelScheduledValues(in float startTime); 58 59 57 }; 60 58 } -
trunk/Source/WebCore/webaudio/RealtimeAnalyserNode.idl
r89148 r89789 25 25 module audio { 26 26 interface [ 27 LegacyDefaultOptionalArguments,28 27 Conditional=WEB_AUDIO, 29 28 GenerateToJS … … 35 34 attribute float minDecibels; 36 35 attribute float maxDecibels; 37 36 38 37 // A value from 0.0 -> 1.0 where 0.0 represents no time averaging with the last analysis frame. 39 38 attribute float smoothingTimeConstant; 40 39 41 40 // Copies the current frequency data into the passed array. 42 41 // If the array has fewer elements than the frequencyBinCount, the excess elements will be dropped.
Note: See TracChangeset
for help on using the changeset viewer.