Changeset 89897 in webkit
- Timestamp:
- Jun 27, 2011 11:46:38 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r89888 r89897 1 2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r89881. 4 http://trac.webkit.org/changeset/89881 5 https://bugs.webkit.org/show_bug.cgi?id=63513 6 7 Makes Qt massively slow (Requested by abarth on #webkit). 8 9 * Scripts/webkitpy/common/system/crashlogs.py: 10 * Scripts/webkitpy/common/system/crashlogs_unittest.py: 11 * Scripts/webkitpy/common/system/executive.py: 12 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 13 * Scripts/webkitpy/layout_tests/port/base.py: 14 * Scripts/webkitpy/layout_tests/port/mac.py: 15 * Scripts/webkitpy/layout_tests/port/server_process.py: 16 * Scripts/webkitpy/tool/commands/queries.py: 17 1 18 2011-06-27 Alice Boxhall <aboxhall@chromium.org> 2 19 -
trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py
r89881 r89897 37 37 38 38 class CrashLogs(object): 39 def __init__(self, filesystem): 39 def __init__(self, executive, filesystem): 40 self._executive = executive 40 41 self._filesystem = filesystem 41 42 … … 61 62 if not logs: 62 63 return 64 65 # FIXME: We should wait for the CrashReporter to finish, but that causes tests to timeout. 66 if False: 67 self._executive.wait_newest(_is_crash_reporter) 63 68 return self._filesystem.read_text_file(sorted(logs)[-1]) -
trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
r89881 r89897 38 38 files['/Users/mock/Library/Logs/DiagnosticReports/TextMate_2011-06-13-150719_quadzen.crash'] = mock_crash_report 39 39 filesystem = MockFileSystem(files) 40 crash_logs = CrashLogs( filesystem)40 crash_logs = CrashLogs(Mock(), filesystem) 41 41 log = crash_logs.find_newest_log("TextMate") 42 42 self.assertTrue(log, mock_crash_report) -
trunk/Tools/Scripts/webkitpy/common/system/executive.py
r89881 r89897 297 297 298 298 if sys.platform in ("win32", "cygwin"): 299 # FIXME: running_pids isn't implemented on Windows yet... 300 return [] 299 raise NotImplemented() 301 300 302 301 ps_process = self.popen(['ps', '-eo', 'pid,comm'], stdout=self.PIPE, stderr=self.PIPE) -
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py
r89881 r89897 174 174 fs.maybe_make_directory(fs.dirname(filename)) 175 175 # FIXME: We shouldn't be grabbing private members of port. 176 crash_logs = CrashLogs( fs)176 crash_logs = CrashLogs(self._port._executive, fs) 177 177 log = crash_logs.find_newest_log(self._port.driver_name()) 178 178 # CrashLogs doesn't support every platform, so we fall back to -
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
r89881 r89897 289 289 return ''.join(diff) 290 290 291 def is_crash_reporter(self, process_name):292 return False293 294 291 def driver_name(self): 295 292 """Returns the name of the actual binary that is performing the test, -
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
r89881 r89897 31 31 import logging 32 32 import platform 33 import re34 33 35 34 from webkitpy.layout_tests.port.webkit import WebKitPort … … 101 100 'mac', 'test_expectations.txt') 102 101 103 def is_crash_reporter(self, process_name):104 return re.search(r'ReportCrash', process_name)105 106 102 def _skipped_file_paths(self): 107 103 # FIXME: This method will need to be made work for non-mac -
trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
r89881 r89897 168 168 deadline = time.time() + timeout 169 169 while not self.timed_out and not self.crashed: 170 if self._executive.running_pids(self._port.is_crash_reporter):171 _log.warning('%s is waiting for crash reporter...' % self._name)172 self._executive.wait_newest(self._port.is_crash_reporter)173 174 170 # poll() is not threadsafe and can throw OSError due to: 175 171 # http://bugs.python.org/issue1731717 -
trunk/Tools/Scripts/webkitpy/tool/commands/queries.py
r89881 r89897 374 374 375 375 def execute(self, options, args, tool): 376 crash_logs = CrashLogs(tool. filesystem)376 crash_logs = CrashLogs(tool.executive, tool.filesystem) 377 377 print crash_logs.find_newest_log(args[0]) 378 378
Note: See TracChangeset
for help on using the changeset viewer.