Changeset 89897 in webkit


Ignore:
Timestamp:
Jun 27, 2011 11:46:38 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89881.
http://trac.webkit.org/changeset/89881
https://bugs.webkit.org/show_bug.cgi?id=63513

Makes Qt massively slow (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
Location:
trunk/Tools
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r89888 r89897  
     12011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r89881.
     4        http://trac.webkit.org/changeset/89881
     5        https://bugs.webkit.org/show_bug.cgi?id=63513
     6
     7        Makes Qt massively slow (Requested by abarth on #webkit).
     8
     9        * Scripts/webkitpy/common/system/crashlogs.py:
     10        * Scripts/webkitpy/common/system/crashlogs_unittest.py:
     11        * Scripts/webkitpy/common/system/executive.py:
     12        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
     13        * Scripts/webkitpy/layout_tests/port/base.py:
     14        * Scripts/webkitpy/layout_tests/port/mac.py:
     15        * Scripts/webkitpy/layout_tests/port/server_process.py:
     16        * Scripts/webkitpy/tool/commands/queries.py:
     17
    1182011-06-27  Alice Boxhall  <aboxhall@chromium.org>
    219
  • trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py

    r89881 r89897  
    3737
    3838class CrashLogs(object):
    39     def __init__(self, filesystem):
     39    def __init__(self, executive, filesystem):
     40        self._executive = executive
    4041        self._filesystem = filesystem
    4142
     
    6162        if not logs:
    6263            return
     64
     65        # FIXME: We should wait for the CrashReporter to finish, but that causes tests to timeout.
     66        if False:
     67            self._executive.wait_newest(_is_crash_reporter)
    6368        return self._filesystem.read_text_file(sorted(logs)[-1])
  • trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

    r89881 r89897  
    3838        files['/Users/mock/Library/Logs/DiagnosticReports/TextMate_2011-06-13-150719_quadzen.crash'] = mock_crash_report
    3939        filesystem = MockFileSystem(files)
    40         crash_logs = CrashLogs(filesystem)
     40        crash_logs = CrashLogs(Mock(), filesystem)
    4141        log = crash_logs.find_newest_log("TextMate")
    4242        self.assertTrue(log, mock_crash_report)
  • trunk/Tools/Scripts/webkitpy/common/system/executive.py

    r89881 r89897  
    297297
    298298        if sys.platform in ("win32", "cygwin"):
    299             # FIXME: running_pids isn't implemented on Windows yet...
    300             return []
     299            raise NotImplemented()
    301300
    302301        ps_process = self.popen(['ps', '-eo', 'pid,comm'], stdout=self.PIPE, stderr=self.PIPE)
  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py

    r89881 r89897  
    174174        fs.maybe_make_directory(fs.dirname(filename))
    175175        # FIXME: We shouldn't be grabbing private members of port.
    176         crash_logs = CrashLogs(fs)
     176        crash_logs = CrashLogs(self._port._executive, fs)
    177177        log = crash_logs.find_newest_log(self._port.driver_name())
    178178        # CrashLogs doesn't support every platform, so we fall back to
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py

    r89881 r89897  
    289289        return ''.join(diff)
    290290
    291     def is_crash_reporter(self, process_name):
    292         return False
    293 
    294291    def driver_name(self):
    295292        """Returns the name of the actual binary that is performing the test,
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py

    r89881 r89897  
    3131import logging
    3232import platform
    33 import re
    3433
    3534from webkitpy.layout_tests.port.webkit import WebKitPort
     
    101100           'mac', 'test_expectations.txt')
    102101
    103     def is_crash_reporter(self, process_name):
    104         return re.search(r'ReportCrash', process_name)
    105 
    106102    def _skipped_file_paths(self):
    107103        # FIXME: This method will need to be made work for non-mac
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py

    r89881 r89897  
    168168        deadline = time.time() + timeout
    169169        while not self.timed_out and not self.crashed:
    170             if self._executive.running_pids(self._port.is_crash_reporter):
    171                 _log.warning('%s is waiting for crash reporter...' % self._name)
    172                 self._executive.wait_newest(self._port.is_crash_reporter)
    173 
    174170            # poll() is not threadsafe and can throw OSError due to:
    175171            # http://bugs.python.org/issue1731717
  • trunk/Tools/Scripts/webkitpy/tool/commands/queries.py

    r89881 r89897  
    374374
    375375    def execute(self, options, args, tool):
    376         crash_logs = CrashLogs(tool.filesystem)
     376        crash_logs = CrashLogs(tool.executive, tool.filesystem)
    377377        print crash_logs.find_newest_log(args[0])
    378378
Note: See TracChangeset for help on using the changeset viewer.