Changeset 89947 in webkit

Timestamp:

Jun 28, 2011 12:01:29 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-28 Chang Shu <​cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Random crashes in fast/frames/ tests
​https://bugs.webkit.org/show_bug.cgi?id=63459

Investigation on the crashes has revealed that sometimes, a frame could
have been destroyed before it is removed from the hierachy in Qt WebKit2 UI process.
The root cause lies in the fact that the order of the two contiguous asynchronous
messages may not be respected on the receiving side. And it is Qt's implementation,
which uses QTimer::startTimer(0), that causes the reverse order. This patch replaces
the timer approach with QMetaObject::invokeMethod approach and no crash happens afterwards.

• Platform/qt/WorkQueueQt.cpp: (WorkQueue::scheduleWork):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/qt/WorkQueueQt.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-06-28  Chang Shu  <cshu@webkit.org>
+
+        Reviewed by Andreas Kling.
+
+        [Qt][WK2] Random crashes in fast/frames/ tests
+        https://bugs.webkit.org/show_bug.cgi?id=63459
+
+        Investigation on the crashes has revealed that sometimes, a frame could
+        have been destroyed before it is removed from the hierachy in Qt WebKit2 UI process.
+        The root cause lies in the fact that the order of the two contiguous asynchronous
+        messages may not be respected on the receiving side. And it is Qt's implementation,
+        which uses QTimer::startTimer(0), that causes the reverse order. This patch replaces
+        the timer approach with QMetaObject::invokeMethod approach and no crash happens afterwards.
+
+        * Platform/qt/WorkQueueQt.cpp:
+        (WorkQueue::scheduleWork):
+
 2011-06-28  Balazs Kelemen  <kbalazs@webkit.org>
 

trunk/Source/WebKit2/Platform/qt/WorkQueueQt.cpp

@@ -108 +108 @@
 {
     WorkQueue::WorkItemQt* itemQt = new WorkQueue::WorkItemQt(this, item.leakPtr());
-    itemQt->startTimer(0);
     itemQt->moveToThread(m_workThread);
+    QMetaObject::invokeMethod(itemQt, "execute", Qt::QueuedConnection);
 }