Changeset 89989 in webkit
- Timestamp:
- Jun 28, 2011 11:05:16 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r89988 r89989 1 2011-06-28 Dimitri Glazkov <dglazkov@chromium.org> 2 3 Reviewed by Kent Tamura. 4 5 Store shadowPseudoId in ElementRareData. 6 https://bugs.webkit.org/show_bug.cgi?id=63604 7 8 No new tests, because the code isn't yet used. 9 10 * css/CSSSelector.cpp: 11 (WebCore::CSSSelector::isUnknownPseudoType): Added convenience helper. 12 * css/CSSSelector.h: Added decl. 13 * dom/Element.cpp: 14 (WebCore::Element::shadowPseudoId): Changed to use ElementRareData. 15 (WebCore::Element::setShadowPseudoId): Ditto. 16 * dom/Element.h: Added decls. 17 * dom/ElementRareData.h: Added a member to keep shadowPseudoId. 18 1 19 2011-06-28 Kenichi Ishibashi <bashi@chromium.org> 2 20 -
trunk/Source/WebCore/css/CSSSelector.cpp
r88115 r89989 393 393 } 394 394 395 bool CSSSelector::isUnknownPseudoType(const AtomicString& name) 396 { 397 return parsePseudoType(name) == PseudoUnknown; 398 } 399 395 400 void CSSSelector::extractPseudoType() const 396 401 { -
trunk/Source/WebCore/css/CSSSelector.h
r88115 r89989 214 214 215 215 static PseudoType parsePseudoType(const AtomicString&); 216 static bool isUnknownPseudoType(const AtomicString&); 216 217 static PseudoId pseudoId(PseudoType); 217 218 -
trunk/Source/WebCore/dom/Element.cpp
r89521 r89989 1235 1235 } 1236 1236 1237 const AtomicString& Element::shadowPseudoId() const 1238 { 1239 return hasRareData() ? rareData()->m_shadowPseudoId : nullAtom; 1240 } 1241 1242 void Element::setShadowPseudoId(const AtomicString& id, ExceptionCode& ec) 1243 { 1244 if (!hasRareData() && id == nullAtom) 1245 return; 1246 1247 if (!CSSSelector::isUnknownPseudoType(id)) { 1248 ec = SYNTAX_ERR; 1249 return; 1250 } 1251 1252 ensureRareData()->m_shadowPseudoId = id; 1253 } 1254 1237 1255 bool Element::childTypeAllowed(NodeType type) const 1238 1256 { -
trunk/Source/WebCore/dom/Element.h
r89205 r89989 236 236 237 237 virtual const AtomicString& shadowPseudoId() const; 238 void setShadowPseudoId(const AtomicString&, ExceptionCode&); 238 239 239 240 RenderStyle* computedStyle(PseudoId = NOPSEUDO); … … 543 544 } 544 545 545 inline const AtomicString& Element::shadowPseudoId() const546 {547 return nullAtom;548 }549 550 546 inline Element* firstElementChild(const ContainerNode* container) 551 547 { -
trunk/Source/WebCore/dom/ElementRareData.h
r87660 r89989 46 46 RefPtr<RenderStyle> m_computedStyle; 47 47 ShadowRoot* m_shadowRoot; 48 AtomicString m_shadowPseudoId; 48 49 49 50 OwnPtr<DatasetDOMStringMap> m_datasetDOMStringMap;
Note: See TracChangeset
for help on using the changeset viewer.