Changeset 90064 in webkit

Timestamp:

Jun 29, 2011 4:45:52 PM (13 years ago)

Author:

rniwa@webkit.org

Message:

2011-06-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r89952): r89952 added a wrong assertion in visible_units.cpp
​https://bugs.webkit.org/show_bug.cgi?id=63668

We need to assert the offset to be zero only when the position is NOT offset in node.

• editing/visible_units.cpp: (WebCore::startOfParagraph):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/visible_units.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION(r89952): r89952 added a wrong assertion in visible_units.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=63668
+
+        We need to assert the offset to be zero only when the position is NOT offset in node.
+
+        * editing/visible_units.cpp:
+        (WebCore::startOfParagraph):
+
 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/Source/WebCore/editing/visible_units.cpp

@@ -819 +819 @@
 
     if (type == Position::PositionIsOffsetInAnchor) {
-        ASSERT(type != Position::PositionIsOffsetInAnchor || !offset);
+        ASSERT(type == Position::PositionIsOffsetInAnchor || !offset);
         return VisiblePosition(Position(node, offset, type), DOWNSTREAM);
     }