Changeset 90083 in webkit

Timestamp:

Jun 29, 2011 8:07:40 PM (13 years ago)

Author:

bashi@chromium.org

Message:

2011-06-29 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Adam Barth.

check-webkit-style fails to detect ​https://webkit.org/b/XXXXX as a bug number
​https://webkit.org/b/57360

Modify the regular expression to match https scheme.

• Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for ​https://webkit.org/b/XXXXX.
• Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/changelog_unittest.py (modified) (1 diff)
• Scripts/webkitpy/common/config/urls.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-29  Kenichi Ishibashi  <bashi@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
+        https://webkit.org/b/57360
+
+        Modify the regular expression to match https scheme.
+
+        * Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
+        * Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
+
 2011-06-29  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py

@@ -137 +137 @@
         self.assertEquals(57569, parse_bug_id_from_changelog(commit_text))
 
+        commit_text = '''
+2011-03-29  Timothy Hatcher  <timothy@apple.com>
+
+        Update WebCore Localizable.strings to contain WebCore, WebKit/mac and WebKit2 strings.
+
+        https://webkit.org/b/57354
+
+        Reviewed by Sam Weinig.
+
+        * English.lproj/Localizable.strings: Updated.
+        * StringsNotToBeLocalized.txt: Removed. To hard to maintain in WebCore.
+        * platform/network/cf/LoaderRunLoopCF.h: Remove a single quote in an #error so
+        extract-localizable-strings does not complain about unbalanced single quotes.
+        '''
+
+        self.assertEquals(57354, parse_bug_id_from_changelog(commit_text))
+
     def test_latest_entry_parse(self):
         changelog_contents = u"%s\n%s" % (self._example_entry, self._example_changelog)

trunk/Tools/Scripts/webkitpy/common/config/urls.py

@@ -48 +48 @@
 bug_server_url = "https://%s/" % bug_server_host
 bug_url_long = _bug_server_regex + r"show_bug\.cgi\?id=(?P<bug_id>\d+)(&ctype=xml)?"
-bug_url_short = r"http\://webkit\.org/b/(?P<bug_id>\d+)"
+bug_url_short = r"https?\://webkit\.org/b/(?P<bug_id>\d+)"