Changeset 90085 in webkit
- Timestamp:
- Jun 29, 2011 8:40:01 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r90083 r90085 1 2011-06-29 Yuta Kitamura <yutak@chromium.org> 2 3 Reviewed by Kent Tamura. 4 5 DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController 6 https://bugs.webkit.org/show_bug.cgi?id=63532 7 8 LayoutTestController::overridePreference() will be used to change the value of 9 the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way, 10 we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but 11 at least we need to reset preference values in DumpRenderTree every time we start 12 a new test because preference values changed in some test should not be leaked 13 to the next test. 14 15 * DumpRenderTree/chromium/LayoutTestController.cpp: 16 (LayoutTestController::overridePreference): 17 The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h. 18 * DumpRenderTree/chromium/WebPreferences.cpp: 19 (WebPreferences::reset): 20 Set the default value. This will be called from TestShell::resetTestController(). 21 (WebPreferences::applyTo): 22 * DumpRenderTree/chromium/WebPreferences.h: 23 * DumpRenderTree/mac/DumpRenderTree.mm: 24 (resetDefaultsToConsistentValues): Set the default value. 25 * DumpRenderTree/win/DumpRenderTree.cpp: 26 (resetDefaultsToConsistentValues): Ditto. 27 1 28 2011-06-29 Kenichi Ishibashi <bashi@chromium.org> 2 29 -
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
r89764 r90085 1426 1426 else if (key == "WebKitAllowRunningInsecureContent") 1427 1427 prefs->allowRunningOfInsecureContent = cppVariantToBool(value); 1428 else if (key == "WebKitHixie76WebSocketProtocolEnabled") 1429 prefs->hixie76WebSocketProtocolEnabled = cppVariantToBool(value); 1428 1430 else { 1429 1431 string message("Invalid name for preference: "); -
trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp
r86201 r90085 111 111 acceleratedDrawingEnabled = false; 112 112 forceCompositingMode = false; 113 hixie76WebSocketProtocolEnabled = true; 113 114 } 114 115 … … 163 164 settings->setLegacyAccelerated2dCanvasEnabled(legacyAccelerated2dCanvasEnabled); 164 165 settings->setAcceleratedDrawingEnabled(acceleratedDrawingEnabled); 166 settings->setHixie76WebSocketProtocolEnabled(hixie76WebSocketProtocolEnabled); 165 167 166 168 // Fixed values. -
trunk/Tools/DumpRenderTree/chromium/WebPreferences.h
r86201 r90085 86 86 bool legacyAccelerated2dCanvasEnabled; 87 87 bool acceleratedDrawingEnabled; 88 bool hixie76WebSocketProtocolEnabled; 88 89 89 90 WebPreferences() { reset(); } -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r89733 r90085 478 478 [preferences setUsePreHTML5ParserQuirks:NO]; 479 479 [preferences setAsynchronousSpellCheckingEnabled:NO]; 480 [preferences setHixie76WebSocketProtocolEnabled:YES]; 480 481 481 482 [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain]; -
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp
r83656 r90085 878 878 prefsPrivate->setOfflineWebApplicationCacheEnabled(TRUE); 879 879 prefsPrivate->setLoadsSiteIconsIgnoringImageLoadingPreference(FALSE); 880 prefsPrivate->setHixie76WebSocketProtocolEnabled(TRUE); 880 881 } 881 882 setAlwaysAcceptCookies(false);
Note: See TracChangeset
for help on using the changeset viewer.