Changeset 90240 in webkit

Timestamp:

Jul 1, 2011 9:56:20 AM (13 years ago)

Author:

joone.hur@collabora.co.uk

Message:

2011-07-01 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
​https://bugs.webkit.org/show_bug.cgi?id=63720

Add configure option to enable/disable DeviceOrientation feature.

• configure.ac:

2011-07-01 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
​https://bugs.webkit.org/show_bug.cgi?id=63720

Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.

• GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.

2011-07-01 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add DeviceOrientation feature
​https://bugs.webkit.org/show_bug.cgi?id=63720

Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.

• GNUmakefile.am:
• WebCoreSupport/DeviceMotionClientGtk.cpp: Added. (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk): (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientGtk::setController): (WebCore::DeviceMotionClientGtk::startUpdating): (WebCore::DeviceMotionClientGtk::stopUpdating): (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
• WebCoreSupport/DeviceMotionClientGtk.h: Added.
• WebCoreSupport/DeviceOrientationClientGtk.cpp: Added. (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk): (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientGtk::setController): (WebCore::DeviceOrientationClientGtk::startUpdating): (WebCore::DeviceOrientationClientGtk::stopUpdating): (WebCore::DeviceOrientationClientGtk::lastOrientation):
• WebCoreSupport/DeviceOrientationClientGtk.h: Added.
• webkit/webkitwebview.cpp: (webkit_web_view_init):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/GNUmakefile.am (modified) (1 diff)
• Source/WebKit/gtk/ChangeLog (modified) (1 diff)
• Source/WebKit/gtk/GNUmakefile.am (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/DeviceMotionClientGtk.cpp (added)
• Source/WebKit/gtk/WebCoreSupport/DeviceMotionClientGtk.h (added)
• Source/WebKit/gtk/WebCoreSupport/DeviceOrientationClientGtk.cpp (added)
• Source/WebKit/gtk/WebCoreSupport/DeviceOrientationClientGtk.h (added)
• Source/WebKit/gtk/webkit/webkitwebview.cpp (modified) (2 diffs)
• configure.ac (modified) (3 diffs)

trunk/ChangeLog

@@ +1 @@
+2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Add DeviceOrientation feature
+        https://bugs.webkit.org/show_bug.cgi?id=63720
+
+        Add configure option to enable/disable DeviceOrientation feature.
+
+        * configure.ac:
+
 2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Add DeviceOrientation feature
+        https://bugs.webkit.org/show_bug.cgi?id=63720
+
+        Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.
+
+        * GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.
+
 2011-07-01  Kentaro Hara  <haraken@google.com>
 

trunk/Source/WebCore/GNUmakefile.am

@@ -604 +604 @@
 endif  # END ENABLE_REGISTER_PROTOCOL_HANDLER
 
+# ---
+# DeviceOrientation support
+# ---
+if ENABLE_DEVICE_ORIENTATION
+FEATURE_DEFINES += ENABLE_DEVICE_ORIENTATION=1
+webcore_cppflags += -DENABLE_DEVICE_ORIENTATION=1
+endif  # END ENABLE_DEVICE_ORIENTATION
+
 DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h
 DerivedSources/WebCore/CSSPropertyNames.h: $(WEBCORE_CSS_PROPERTY_NAMES) $(WebCore)/css/makeprop.pl

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Add DeviceOrientation feature
+        https://bugs.webkit.org/show_bug.cgi?id=63720
+
+        Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
+
+        * GNUmakefile.am:
+        * WebCoreSupport/DeviceMotionClientGtk.cpp: Added.
+        (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk):
+        (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk):
+        (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed):
+        (WebCore::DeviceMotionClientGtk::setController):
+        (WebCore::DeviceMotionClientGtk::startUpdating):
+        (WebCore::DeviceMotionClientGtk::stopUpdating):
+        (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
+        * WebCoreSupport/DeviceMotionClientGtk.h: Added.
+        * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added.
+        (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk):
+        (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk):
+        (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed):
+        (WebCore::DeviceOrientationClientGtk::setController):
+        (WebCore::DeviceOrientationClientGtk::startUpdating):
+        (WebCore::DeviceOrientationClientGtk::stopUpdating):
+        (WebCore::DeviceOrientationClientGtk::lastOrientation):
+        * WebCoreSupport/DeviceOrientationClientGtk.h: Added.
+        * webkit/webkitwebview.cpp:
+        (webkit_web_view_init):
+
 2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
 

trunk/Source/WebKit/gtk/GNUmakefile.am

@@ -183 +183 @@
         Source/WebKit/gtk/WebCoreSupport/ContextMenuClientGtk.cpp \
         Source/WebKit/gtk/WebCoreSupport/ContextMenuClientGtk.h \
+        Source/WebKit/gtk/WebCoreSupport/DeviceMotionClientGtk.cpp \
+        Source/WebKit/gtk/WebCoreSupport/DeviceMotionClientGtk.h \
+        Source/WebKit/gtk/WebCoreSupport/DeviceOrientationClientGtk.cpp \
+        Source/WebKit/gtk/WebCoreSupport/DeviceOrientationClientGtk.h \
         Source/WebKit/gtk/WebCoreSupport/DocumentLoaderGtk.cpp \
         Source/WebKit/gtk/WebCoreSupport/DocumentLoaderGtk.h \

trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp

@@ -108 +108 @@
 #include <wtf/gobject/GOwnPtr.h>
 #include <wtf/text/CString.h>
+
+#if ENABLE(DEVICE_ORIENTATION)
+#include "DeviceMotionClientGtk.h"
+#include "DeviceOrientationClientGtk.h"
+#endif
 
 /**
@@ -3376 +3381 @@
     pageClients.dragClient = new WebKit::DragClient(webView);
     pageClients.inspectorClient = new WebKit::InspectorClient(webView);
+
+#if ENABLE(DEVICE_ORIENTATION)
+    pageClients.deviceMotionClient = static_cast<WebCore::DeviceMotionClient*>(new DeviceMotionClientGtk);
+    pageClients.deviceOrientationClient = static_cast<WebCore::DeviceOrientationClient*>(new DeviceOrientationClientGtk);
+#endif
+
     priv->corePage = new Page(pageClients);
 

trunk/configure.ac

@@ -928 +928 @@
               [],[enable_register_protocol_handler="no"])
 AC_MSG_RESULT([$enable_register_protocol_handler])
+
+# check whether to enable DeviceOrientation support
+AC_MSG_CHECKING([whether to enable DeviceOrientation])
+AC_ARG_ENABLE(device_orientation,
+              AC_HELP_STRING([--enable-device-orientation],
+                             [enable support for DeviceOrientation (experimental and incomplete) [default=no]]),
+              [],[enable_device_orientation="no"])
+AC_MSG_RESULT([$enable_device_orientation])
 
 G_IR_SCANNER=
@@ -1196 +1204 @@
 AM_CONDITIONAL([ENABLE_TOUCH_ICON_LOADING],[test "$enable_touch_icon_loading" = "yes"])
 AM_CONDITIONAL([ENABLE_REGISTER_PROTOCOL_HANDLER],[test "$enable_register_protocol_handler" = "yes"])
+AM_CONDITIONAL([ENABLE_DEVICE_ORIENTATION],[test "$enable_device_orientation" = "yes"])
 
 # Gtk conditionals
@@ -1246 +1255 @@
  WebGL                                                    : $enable_webgl
  Blob support                                             : $enable_blob
+ DeviceOrientation support                                : $enable_device_orientation
  Directory upload                                         : $enable_directory_upload
  Fast Mobile Scrolling                                    : $enable_fast_mobile_scrolling