Changeset 90405 in webkit


Ignore:
Timestamp:
Jul 5, 2011 1:51:06 PM (13 years ago)
Author:
weinig@apple.com
Message:

2011-07-05 Sam Weinig <​sam@webkit.org>

Null deref accessing CustomEvent.detail
<rdar://problem/9724577>
​https://bugs.webkit.org/show_bug.cgi?id=63885

Reviewed by Anders Carlsson.

Test: fast/events/custom-event-uninitialized.html

  • bindings/scripts/CodeGeneratorJS.pm: Guard against uninitialized script value.

2011-07-05 Sam Weinig <​sam@webkit.org>

Null deref accessing CustomEvent.detail
<rdar://problem/9724577>
​https://bugs.webkit.org/show_bug.cgi?id=63885

Reviewed by Anders Carlsson.

Add test which exercises an initialized details property on
a CustomEvent instance.

  • fast/events/custom-event-uninitialized-expected.txt: Added.
  • fast/events/custom-event-uninitialized.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r90402 r90405  
     12011-07-05  Sam Weinig  <sam@webkit.org>
     2
     3        Null deref accessing CustomEvent.detail
     4        <rdar://problem/9724577>
     5        https://bugs.webkit.org/show_bug.cgi?id=63885
     6
     7        Reviewed by Anders Carlsson.
     8
     9        Add test which exercises an initialized details property on
     10        a CustomEvent instance.
     11
     12        * fast/events/custom-event-uninitialized-expected.txt: Added.
     13        * fast/events/custom-event-uninitialized.html: Added.
     14
    1152011-07-05  Gavin Barraclough  <barraclough@apple.com>
    216

  • trunk/Source/WebCore/ChangeLog

    r90400 r90405  
     12011-07-05  Sam Weinig  <sam@webkit.org>
     2
     3        Null deref accessing CustomEvent.detail
     4        <rdar://problem/9724577>
     5        https://bugs.webkit.org/show_bug.cgi?id=63885
     6
     7        Reviewed by Anders Carlsson.
     8
     9        Test: fast/events/custom-event-uninitialized.html
     10
     11        * bindings/scripts/CodeGeneratorJS.pm:
     12        Guard against uninitialized script value.
     13
    1142011-07-05  Pratik Solanki  <psolanki@apple.com>
    215

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r89315 r90405  
    26862686            $implIncludes{"JSCanvasRenderingContext2D.h"} = 1;
    26872687        } else {
    2688             return "$value.jsValue();";
     2688            return "($value.hasNoValue() ? jsNull() : $value.jsValue())";
    26892689        }
    26902690    } elsif ($type =~ /SVGPathSeg/) {
Note: See TracChangeset for help on using the changeset viewer.