Changeset 90518 in webkit


Ignore:
Timestamp:
Jul 6, 2011 5:09:35 PM (13 years ago)
Author:
jnd@chromium.org
Message:

2011-07-06 Johnny Ding <​jnd@chromium.org>

​https://bugs.webkit.org/show_bug.cgi?id=63857
Remove some crash expectation after implementing "createPopupMenu"

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:

2011-07-06 Johnny Ding <​jnd@chromium.org>

​https://bugs.webkit.org/show_bug.cgi?id=63857
Check WebWidgetClient before calling it to close widget.

Reviewed by Tony Chang.

  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::popupClosed):

2011-07-06 Johnny Ding <​jnd@chromium.org>

​https://bugs.webkit.org/show_bug.cgi?id=63857
Implement createPopupMenu for Chromium DRT.

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createPopupMenu): (WebViewHost::~WebViewHost):
  • DumpRenderTree/chromium/WebViewHost.h:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r90516 r90518  
     12011-07-06  Johnny Ding  <jnd@chromium.org>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=63857
     4        Remove some crash expectation after implementing "createPopupMenu"
     5
     6        Reviewed by Tony Chang.
     7
     8        * platform/chromium/test_expectations.txt:
     9
    1102011-07-06  Mihai Parparita  <mihaip@chromium.org>
    211

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r90516 r90518  
    25652565BUG_DRT MAC : fast/dom/beforeload/script-before-load-dynamic.html = TIMEOUT PASS
    25662566BUG_DRT : fast/dynamic/window-resize-scrollbars-test.html = IMAGE+TEXT
    2567 BUG_DRT LINUX : fast/events/select-onchange-crash.html = CRASH
    25682567BUG_DRT DEBUG : fast/frames/calculate-round.html = TIMEOUT PASS
    25692568BUG_DRT BUGCR43890 WIN DEBUG SLOW : fast/forms/implicit-submission.html = PASS TEXT
    25702569BUG_DRT BUGCR43890 LINUX : fast/forms/implicit-submission.html = CRASH
    25712570BUG_DRT BUGCR43890 MAC DEBUG SLOW : fast/forms/implicit-submission.html = PASS TEXT
    2572 BUG_DRT BUGCR21141 LINUX : fast/forms/select-double-onchange.html = CRASH FAIL
    2573 BUG_DRT BUGCR21141 LINUX : fast/forms/select-script-onchange.html = CRASH FAIL
     2571BUG_DRT BUGCR21141 LINUX : fast/forms/select-double-onchange.html = FAIL
     2572BUG_DRT BUGCR21141 LINUX : fast/forms/select-script-onchange.html = FAIL
    25742573BUG_DRT MAC : fast/images/extra-image-in-image-document.html = TIMEOUT PASS
    25752574BUG_DRT MAC : fast/loader/font-face-empty.html = TIMEOUT PASS

  • trunk/Source/WebKit/chromium/ChangeLog

    r90505 r90518  
     12011-07-06  Johnny Ding  <jnd@chromium.org>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=63857
     4        Check WebWidgetClient before calling it to close widget. 
     5
     6        Reviewed by Tony Chang.
     7
     8        * src/WebPopupMenuImpl.cpp:
     9        (WebKit::WebPopupMenuImpl::popupClosed):
     10
    1112011-07-06  Adrienne Walker  <enne@google.com>
    212

  • trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp

    r89837 r90518  
    376376        m_widget = 0;
    377377    }
    378     m_client->closeWidgetSoon();
     378    if (m_client)
     379        m_client->closeWidgetSoon();
    379380}
    380381

  • trunk/Tools/ChangeLog

    r90514 r90518  
     12011-07-06  Johnny Ding  <jnd@chromium.org>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=63857
     4        Implement createPopupMenu for Chromium DRT.
     5
     6        Reviewed by Tony Chang.
     7
     8        * DumpRenderTree/chromium/WebViewHost.cpp:
     9        (WebViewHost::createPopupMenu):
     10        (WebViewHost::~WebViewHost):
     11        * DumpRenderTree/chromium/WebViewHost.h:
     12
    1132011-07-06  Mihai Parparita  <mihaip@chromium.org>
    214

  • trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp

    r89837 r90518  
    4747#include "WebHistoryItem.h"
    4848#include "WebNode.h"
     49#include "WebPopupMenu.h"
     50#include "WebPopupType.h"
    4951#include "WebRange.h"
    5052#include "WebRect.h"
    … …  
    237239}
    238240
    239 WebWidget* WebViewHost::createPopupMenu(WebPopupType)
    240 {
     241WebWidget* WebViewHost::createPopupMenu(WebPopupType type)
     242{
     243    switch (type) {
     244    case WebKit::WebPopupTypeNone:
     245        break;
     246    case WebKit::WebPopupTypeSelect:
     247    case WebKit::WebPopupTypeSuggestion:
     248        m_popupmenus.append(WebPopupMenu::create(0));
     249        return m_popupmenus.last();
     250    }
    241251    return 0;
    242252}
    … …  
    244254WebWidget* WebViewHost::createPopupMenu(const WebPopupMenuInfo&)
    245255{
     256    // Do not use this method. It's been replaced by createExternalPopupMenu.
     257    ASSERT_NOT_REACHED();
    246258    return 0;
    247259}
    … …  
    11551167    }
    11561168
     1169    for (Vector<WebKit::WebWidget*>::iterator it = m_popupmenus.begin();
     1170         it < m_popupmenus.end(); ++it)
     1171        (*it)->close();
     1172
    11571173    webWidget()->close();
    1158 
    11591174    if (m_inModalLoop)
    11601175        webkit_support::QuitMessageLoop();

  • trunk/Tools/DumpRenderTree/chromium/WebViewHost.h

    r88246 r90518  
    351351
    352352    TaskList m_taskList;
     353    Vector<WebKit::WebWidget*> m_popupmenus;
    353354};
    354355
Note: See TracChangeset for help on using the changeset viewer.