Changeset 90545 in webkit

Timestamp:

Jul 7, 2011 12:16:48 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-07-07 Adam Barth <​abarth@webkit.org>

REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
​https://bugs.webkit.org/show_bug.cgi?id=64067

Reviewed by Eric Seidel.

The author of r90520 forgot to change the chromium_gpu.py implemenation
of this method as well.

• Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/chromium_gpu.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-07  Adam Barth  <abarth@webkit.org>
+
+        REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
+        https://bugs.webkit.org/show_bug.cgi?id=64067
+
+        Reviewed by Eric Seidel.
+
+        The author of r90520 forgot to change the chromium_gpu.py implemenation
+        of this method as well.
+
+        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+
 2011-07-06  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py

@@ -83 +83 @@
         # See https://bugs.webkit.org/show_bug.cgi?id=53117
         paths += ['plugins/invalidate_rect.html']
-    return test_files.find(port, paths)
+    return set([port.relative_test_filename(f) for f in test_files.find(port, paths)])
 
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py

@@ -80 +80 @@
             self.assertEqual(port._webkit_baseline_path('chromium-gpu'), paths[1])
 
-
         # Test that we're limiting to the correct directories.
         # These two tests are picked mostly at random, but we make sure they
@@ -86 +85 @@
         files = port.tests(None)
 
-        path = port.abspath_for_test('compositing/checkerboard.html')
-        self.assertTrue(port._filesystem.exists(path))
+        path = 'compositing/checkerboard.html'
+        self.assertTrue(port._filesystem.exists(port.abspath_for_test(path)))
         self.assertTrue(path in files)
 
-        path = port.abspath_for_test('fast/html/keygen.html')
-        self.assertTrue(port._filesystem.exists(path))
+        path = 'fast/html/keygen.html'
+        self.assertTrue(port._filesystem.exists(port.abspath_for_test(path)))
         self.assertFalse(path in files)
         if port_name.startswith('chromium-gpu-mac'):
-            path = port.abspath_for_test('fast/canvas/set-colors.html')
-            self.assertTrue(port._filesystem.exists(path))
+            path = 'fast/canvas/set-colors.html'
+            self.assertTrue(port._filesystem.exists(port.abspath_for_test(path)))
             self.assertFalse(path in files)