Changeset 90605 in webkit

Timestamp:

Jul 7, 2011 6:16:07 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
​https://bugs.webkit.org/show_bug.cgi?id=64107

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-07-07
Reviewed by Kent Tamura.

The pointer is later managed by BitmapContext, but it was being
de-refed and deleted earlier by our RefPtr, causing crashes in all
pixel tests.

We now call leakRef() to make sure it is not removed when our
createBitmapContextFromWebView goes out of context.

• DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/efl/PixelDumpSupportEfl.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
+        https://bugs.webkit.org/show_bug.cgi?id=64107
+
+        Reviewed by Kent Tamura.
+
+        The pointer is later managed by BitmapContext, but it was being
+        de-refed and deleted earlier by our RefPtr, causing crashes in all
+        pixel tests.
+
+        We now call leakRef() to make sure it is not removed when our
+        createBitmapContextFromWebView goes out of context.
+
+        * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
+        (createBitmapContextFromWebView):
+
 2011-07-07  Adam Roben  <aroben@apple.com>
 

trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp

@@ -64 +64 @@
     }
 
-    return BitmapContext::createByAdoptingBitmapAndContext(0, context.get());
+    return BitmapContext::createByAdoptingBitmapAndContext(0, context.release().leakRef());
 }