Changeset 90656 in webkit

Timestamp:

Jul 8, 2011 12:51:16 PM (13 years ago)

Author:

Adam Roben

Message:

Make TestFailures remember that run-webkit-tests timed out, even across reloads

Fixes <​http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
​http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
When true, it indicates that there was an error retrieving the results for this build and
that the errorCallback should be called.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js

@@ -31 +31 @@
     start: function(buildName, callback, errorCallback) {
         var cacheKey = 'LayoutTestResultsLoader.' + this._builder.name + '.' + buildName;
-        const currentCachedDataVersion = 2;
+        const currentCachedDataVersion = 3;
         if (PersistentCache.contains(cacheKey)) {
             var cachedData = PersistentCache.get(cacheKey);
             if (cachedData.version === currentCachedDataVersion) {
-                callback(cachedData.tests, cachedData.tooManyFailures);
+                if (cachedData.error)
+                    errorCallback(cachedData.tests, cachedData.tooManyFailures);
+                else
+                    callback(cachedData.tests, cachedData.tooManyFailures);
                 return;
             }
         }
 
-        var result = { tests: {}, tooManyFailures: false, version: currentCachedDataVersion };
+        var result = { tests: {}, tooManyFailures: false, error: false, version: currentCachedDataVersion };
 
         function cacheParseResultsAndCallCallback(parseResult) {
@@ -54 +57 @@
             self._fetchAndParseORWTResults(buildName, cacheParseResultsAndCallCallback, function() {
                 // We couldn't fetch results for this build.
+                result.error = true;
                 PersistentCache.set(cacheKey, result);
                 errorCallback(result.tests, result.tooManyFailures);

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-08  Adam Roben  <aroben@apple.com>
+
+        Make TestFailures remember that run-webkit-tests timed out, even across reloads
+
+        Fixes <http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
+        http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload
+
+        Reviewed by Daniel Bates.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
+        (LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
+        When true, it indicates that there was an error retrieving the results for this build and
+        that the errorCallback should be called.
+
 2011-07-08  Adam Barth  <abarth@webkit.org>