Changeset 90682 in webkit

Timestamp:

Jul 9, 2011 12:05:44 PM (13 years ago)

Author:

Adam Roben

Message:

Teach TestFailures to abbreviate the examples of test flakiness

These lists can get quite long, and it's not really helpful in most cases to have soooooo
many examples of flakiness.

Fixes <​http://webkit.org/b/64203> Lists of flaky revisions on TestFailures page can get so
long they're hard to navigate

Reviewed by Dan Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector.prototype.flakinessExamples): If we have more than a certain number
of examples, replace the middle items with a separator.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.flakiness-example-separator): Added styles for the separator.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForPossiblyFlakyTests): Use a vertical ellipsis to represent
the separator.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js

@@ -89 +89 @@
         }
 
+        // The list of examples can get quite long. Instead of showing the whole list, we abbreviate
+        // by replacing the middle items with a separator.
+        const startAndEndAbbreviatedExamplesCount = 3;
+        console.assert(startAndEndAbbreviatedExamplesCount > 1);
+        var abbreviatedExamplesToShow = 2 * startAndEndAbbreviatedExamplesCount;
+        if (examples.length > abbreviatedExamplesToShow) {
+            var examplesBeforeSeparator = examples.slice(0, startAndEndAbbreviatedExamplesCount);
+            var examplesAfterSeparator = examples.slice(-startAndEndAbbreviatedExamplesCount);
+
+            // There's no real use in having two "pass" examples in a row immediately next to the
+            // separator.
+            if (examplesBeforeSeparator[examplesBeforeSeparator.length - 1].result.failureType === 'pass' && examplesBeforeSeparator[examplesBeforeSeparator.length - 2].result.failureType === 'pass')
+                examplesBeforeSeparator.splice(examplesBeforeSeparator.length - 1, 1);
+            if (examplesAfterSeparator[0].result.failureType === 'pass' && examplesAfterSeparator[1].result.failureType === 'pass')
+                examplesAfterSeparator.splice(0, 1);
+            examples = examplesBeforeSeparator.concat({ isSeparator: true }, examplesAfterSeparator);
+        }
+
         return examples;
     },

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css

@@ -60 +60 @@
     display: none;
 }
+
+.flakiness-example-separator {
+    padding-left: 5em;
+    font-size: larger;
+}

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js

@@ -512 +512 @@
             historyList.appendChildren(possiblyFlakyTestData[testName].map(function(historyItem) {
                 var item = document.createElement('li');
+                if (historyItem.isSeparator) {
+                    const verticalEllipsis = '\u22ee';
+                    item.appendChild(document.createTextNode(verticalEllipsis));
+                    item.className = 'flakiness-example-separator';
+                    return item;
+                }
                 item.appendChild(self._domForBuildName(builder, historyItem.build));
                 item.appendChild(document.createTextNode(': '));

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-09  Adam Roben  <aroben@apple.com>
+
+        Teach TestFailures to abbreviate the examples of test flakiness
+
+        These lists can get quite long, and it's not really helpful in most cases to have soooooo
+        many examples of flakiness.
+
+        Fixes <http://webkit.org/b/64203> Lists of flaky revisions on TestFailures page can get so
+        long they're hard to navigate
+
+        Reviewed by Dan Bates.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
+        (FlakyLayoutTestDetector.prototype.flakinessExamples): If we have more than a certain number
+        of examples, replace the middle items with a separator.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
+        (.flakiness-example-separator): Added styles for the separator.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+        (ViewController.prototype._domForPossiblyFlakyTests): Use a vertical ellipsis to represent
+        the separator.
+
 2011-07-09  Dirk Pranke  <dpranke@chromium.org>