Changeset 90697 in webkit


Ignore:
Timestamp:
Jul 10, 2011 11:55:22 AM (13 years ago)
Author:
abarth@webkit.org
Message:

Clean up style in fallback path calculation
https://bugs.webkit.org/show_bug.cgi?id=64239

Reviewed by Daniel Bates.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r90693 r90697  
     12011-07-10  Adam Barth  <abarth@webkit.org>
     2
     3        Clean up style in fallback path calculation
     4        https://bugs.webkit.org/show_bug.cgi?id=64239
     5
     6        Reviewed by Daniel Bates.
     7
     8        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
     9        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
     10        * Scripts/webkitpy/layout_tests/port/mac.py:
     11        * Scripts/webkitpy/layout_tests/port/win.py:
     12
    1132011-07-10  Balazs Kelemen  <kbalazs@webkit.org>
    214
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py

    r90543 r90697  
    4242
    4343    FALLBACK_PATHS = {
    44         'x86_64': ['chromium-linux', 'chromium-win', 'chromium', 'win', 'mac'],
    45         'x86': ['chromium-linux-x86', 'chromium-linux', 'chromium-win', 'chromium', 'win', 'mac'],
     44        'x86_64': [
     45            'chromium-linux',
     46            'chromium-win',
     47            'chromium',
     48            'win',
     49            'mac',
     50        ],
     51        'x86': [
     52            'chromium-linux-x86',
     53            'chromium-linux',
     54            'chromium-win',
     55            'chromium',
     56            'win',
     57            'mac',
     58        ],
    4659    }
    4760
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py

    r90534 r90697  
    6363    # FIXME: Do we need mac-snowleopard here, like the base win port?
    6464    FALLBACK_PATHS = {
    65         'xp': ['chromium-win-xp', 'chromium-win-vista', 'chromium-win', 'chromium', 'win', 'mac'],
    66         'vista': ['chromium-win-vista', 'chromium-win', 'chromium', 'win', 'mac'],
    67         'win7': ['chromium-win', 'chromium', 'win', 'mac'],
     65        'xp': [
     66            'chromium-win-xp',
     67            'chromium-win-vista',
     68            'chromium-win',
     69            'chromium',
     70            'win',
     71            'mac',
     72        ],
     73        'vista': [
     74            'chromium-win-vista',
     75            'chromium-win',
     76            'chromium',
     77            'win',
     78            'mac',
     79        ],
     80        'win7': [
     81            'chromium-win',
     82            'chromium',
     83            'win',
     84            'mac',
     85        ],
    6886    }
    6987
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py

    r90543 r90697  
    6767
    6868    FALLBACK_PATHS = {
    69         'leopard': ['mac-leopard', 'mac-snowleopard', 'mac'],
    70         'snowleopard': ['mac-snowleopard', 'mac'],
    71         'future': ['mac'],
     69        'leopard': [
     70            'mac-leopard',
     71            'mac-snowleopard',
     72            'mac',
     73        ],
     74        'snowleopard': [
     75            'mac-snowleopard',
     76            'mac',
     77        ],
     78        'future': [
     79            'mac',
     80        ],
    7281        'wk2': [],  # wk2 does not make sense as a version, this is only here to make the rebaseline unit tests not crash.
    7382    }
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py

    r90543 r90697  
    4040    port_name = "win"
    4141
     42    FALLBACK_PATHS = {
     43        'win7': [
     44            "win",
     45            "mac-snowleopard",
     46            "mac",
     47        ],
     48    }
     49
    4250    def __init__(self, **kwargs):
    4351        WebKitPort.__init__(self, **kwargs)
     
    4856        # Based on code from old-run-webkit-tests expectedDirectoryForTest()
    4957        # FIXME: This does not work for WebKit2.
    50         port_names = ["win", "mac-snowleopard", "mac"]
    51         return map(self._webkit_baseline_path, port_names)
     58        return map(self._webkit_baseline_path, self.FALLBACK_PATHS[self._version])
    5259
    5360    def _path_to_apache_config_file(self):
Note: See TracChangeset for help on using the changeset viewer.