Changeset 90738 in webkit

Timestamp:

Jul 11, 2011 5:32:18 AM (13 years ago)

Author:

loki@webkit.org

Message:

Fix the condition of the optimized code in doubleTransfer
​https://bugs.webkit.org/show_bug.cgi?id=64261

Reviewed by Zoltan Herczeg.

The condition of the optimized code in doubleTransfer is wrong. The
data transfer should be executed with four bytes aligned address.
VFP cannot perform unaligned memory access.

Reported by Jacob Bramley.

• assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::doubleTransfer):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/ARMAssembler.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-07-11  Gabor Loki  <loki@webkit.org>
+
+        Fix the condition of the optimized code in doubleTransfer
+        https://bugs.webkit.org/show_bug.cgi?id=64261
+
+        Reviewed by Zoltan Herczeg.
+
+        The condition of the optimized code in doubleTransfer is wrong. The
+        data transfer should be executed with four bytes aligned address.
+        VFP cannot perform unaligned memory access.
+
+        Reported by Jacob Bramley.
+
+        * assembler/ARMAssembler.cpp:
+        (JSC::ARMAssembler::doubleTransfer):
+
 2011-07-11  Gabor Loki  <loki@webkit.org>
 

trunk/Source/JavaScriptCore/assembler/ARMAssembler.cpp

@@ -314 +314 @@
 void ARMAssembler::doubleTransfer(bool isLoad, FPRegisterID srcDst, RegisterID base, int32_t offset)
 {
-    if (offset & 0x3) {
+    // VFP cannot directly access memory that is not four-byte-aligned
+    if (!(offset & 0x3)) {
         if (offset <= 0x3ff && offset >= 0) {
             fdtr_u(isLoad, srcDst, base, offset >> 2);