Changeset 90788 in webkit

Timestamp:

Jul 11, 2011 3:43:00 PM (13 years ago)

Author:

Martin Robinson

Message:

Reviewed by Daniel Bates.

[GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering
​https://bugs.webkit.org/show_bug.cgi?id=62752

Instead of offsetting the cursor blit by the hotspot, just pass the hotspot
arguments to the GdkCursor constructor.

No new tests. This is covered by manual-tests/cursor.html.

• platform/gtk/CursorGtk.cpp:

(WebCore::createNamedCursor):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/CursorGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-11  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Daniel Bates.
+
+        [GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering
+        https://bugs.webkit.org/show_bug.cgi?id=62752
+
+        Instead of offsetting the cursor blit by the hotspot, just pass the hotspot
+        arguments to the GdkCursor constructor.
+
+        No new tests. This is covered by manual-tests/cursor.html.
+
+        * platform/gtk/CursorGtk.cpp:
+        (WebCore::createNamedCursor):
+
 2011-07-11  Yi Shen  <yi.4.shen@nokia.com>
 

trunk/Source/WebCore/platform/gtk/CursorGtk.cpp

@@ -53 +53 @@
     RefPtr<cairo_t> cr = adoptRef(cairo_create(surface.get()));
 
-    cairo_set_source_surface(cr.get(), source.get(), cursor.hot_x, cursor.hot_y);
-    cairo_mask_surface(cr.get(), mask.get(), cursor.hot_x, cursor.hot_y);
+    cairo_set_source_surface(cr.get(), source.get(), 0, 0);
+    cairo_mask_surface(cr.get(), mask.get(), 0, 0);
 
     GRefPtr<GdkPixbuf> pixbuf = adoptGRef(gdk_pixbuf_get_from_surface(surface.get(), 0, 0, 32, 32));
-    return adoptGRef(gdk_cursor_new_from_pixbuf(gdk_display_get_default(), pixbuf.get(), 0, 0));
+    return adoptGRef(gdk_cursor_new_from_pixbuf(gdk_display_get_default(), pixbuf.get(), cursor.hot_x, cursor.hot_y));
 }