Changeset 91067 in webkit
- Timestamp:
- Jul 15, 2011 7:38:13 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r91066 r91067 1 2011-07-15 Gabor Loki <loki@webkit.org> 2 3 Pixel difference in FEMorphology effect 4 https://bugs.webkit.org/show_bug.cgi?id=63930 5 6 Reviewed by Zoltan Herczeg. 7 8 Layout test is updated to follow the bugfix. 9 10 * platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: 11 1 12 2011-07-15 Jeff Miller <jeffm@apple.com> 2 13 -
trunk/Source/WebCore/ChangeLog
r91066 r91067 1 2011-07-15 Piroska András <Piroska.Andras@stud.u-szeged.hu> 2 3 Pixel difference in FEMorphology effect 4 https://bugs.webkit.org/show_bug.cgi?id=63930 5 6 Reviewed by Zoltan Herczeg. 7 8 Using short-circuit evaluation in the setFilterEffectAttribute function 9 was wrong. We should call both setRadius functions and evaluate the 10 changes separately. 11 12 * svg/SVGFEMorphologyElement.cpp: 13 (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute): 14 1 15 2011-07-15 Jeff Miller <jeffm@apple.com> 2 16 -
trunk/Source/WebCore/svg/SVGFEMorphologyElement.cpp
r90680 r91067 126 126 if (attrName == SVGNames::operatorAttr) 127 127 return morphology->setMorphologyOperator(_operator()); 128 if (attrName == SVGNames::radiusAttr) 129 return (morphology->setRadiusX(radiusX()) || morphology->setRadiusY(radiusY())); 128 if (attrName == SVGNames::radiusAttr) { 129 // Both setRadius functions should be evaluated separately. 130 bool isRadiusXChanged = morphology->setRadiusX(radiusX()); 131 bool isRadiusYChanged = morphology->setRadiusY(radiusY()); 132 return isRadiusXChanged || isRadiusYChanged; 133 } 130 134 131 135 ASSERT_NOT_REACHED();
Note: See TracChangeset
for help on using the changeset viewer.