Changeset 91068 in webkit


Ignore:
Timestamp:
Jul 15, 2011 8:10:17 AM (13 years ago)
Author:
Adam Roben
Message:

Rename TestFailureBugForm to FailingTestsBugForm

The new name will match better with a forthcoming FlakyTestBugForm class.

Fixes <​http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
name

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Updated for renames.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and

reordered <script>s to put files which others depend on for parsing first.

Location:
trunk/Tools
Files:
4 edited
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js

    r91067 r91068  
    5757};
    5858
    59 function TestFailureBugForm(bugzilla, trac, tester, failingBuildName, passingBuildName, failingTests) {
     59function FailingTestsBugForm(bugzilla, trac, tester, failingBuildName, passingBuildName, failingTests) {
    6060    NewBugForm.call(this, bugzilla);
    6161
    … …  
    8383}
    8484
    85 TestFailureBugForm.prototype = {
     85FailingTestsBugForm.prototype = {
    8686    domElement: function() {
    8787        var form = NewBugForm.prototype.domElement.call(this);
    … …  
    190190};
    191191
    192 TestFailureBugForm.prototype.__proto__ = NewBugForm.prototype;
     192FailingTestsBugForm.prototype.__proto__ = NewBugForm.prototype;

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js

    r91067 r91068  
    2626(function() {
    2727
    28 module('TestFailureBugForm');
     28module('FailingTestsBugForm');
    2929
    3030function MockBuilder(name) {
    … …  
    6060    }
    6161
    62     return new TestFailureBugForm(mockBugzilla, mockTrac, mockBuilder, failingBuildName, passingBuildName, failingTests);
     62    return new FailingTestsBugForm(mockBugzilla, mockTrac, mockBuilder, failingBuildName, passingBuildName, failingTests);
    6363}
    6464

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js

    r91029 r91068  
    386386        });
    387387
    388         var bugForm = new TestFailureBugForm(this._bugzilla, this._trac, tester, failingBuildName, passingBuildName, failingTests);
     388        var bugForm = new FailingTestsBugForm(this._bugzilla, this._trac, tester, failingBuildName, passingBuildName, failingTests);
    389389
    390390        var form = bugForm.domElement();

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html

    r90814 r91068  
    2828<head>
    2929    <link rel="stylesheet" href="TestFailures.css"></link>
     30    <script src="Utilities.js"></script>
    3031    <script src="Bugzilla.js"></script>
     32    <script src="NewBugForm.js"></script>
     33    <script src="FailingTestsBugForm.js"></script>
     34
    3135    <script src="Buildbot.js"></script>
    3236    <script src="Builder.js"></script>
    … …  
    3539    <script src="LayoutTestResultsLoader.js"></script>
    3640    <script src="NRWTResultsParser.js"></script>
    37     <script src="NewBugForm.js"></script>
    3841    <script src="ORWTResultsParser.js"></script>
    3942    <script src="PersistentCache.js"></script>
    40     <script src="TestFailureBugForm.js"></script>
    4143    <script src="Trac.js"></script>
    42     <script src="Utilities.js"></script>
    4344    <script src="ViewController.js"></script>
    4445

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html

    r91029 r91068  
    3030<script src="Builder_unittests.js"></script>
    3131
    32 <script src="TestFailureBugForm.js"></script>
    33 <script src="TestFailureBugForm_unittests.js"></script>
     32<script src="FailingTestsBugForm.js"></script>
     33<script src="FailingTestsBugForm_unittests.js"></script>
    3434</body>
    3535</html>

  • trunk/Tools/ChangeLog

    r91059 r91068  
     12011-07-15  Adam Roben  <aroben@apple.com>
     2
     3        Rename TestFailureBugForm to FailingTestsBugForm
     4
     5        The new name will match better with a forthcoming FlakyTestBugForm class.
     6
     7        Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
     8        name
     9
     10        Reviewed by Daniel Bates.
     11
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
     13        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
     14
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
     16        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
     17        Updated for renames.
     18
     19        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and
     20        reordered <script>s to put files which others depend on for parsing first.
     21
    1222011-07-15  Adam Barth  <abarth@webkit.org>
    223
Note: See TracChangeset for help on using the changeset viewer.