Changeset 91113 in webkit

Timestamp:

Jul 15, 2011 2:24:32 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r90592.
​http://trac.webkit.org/changeset/90592
​https://bugs.webkit.org/show_bug.cgi?id=64627

Causes crashes with the web audio async decoding API
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-15

• html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

• manual-tests/array-buffer-memory.html: Removed.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/ArrayBuffer.cpp (modified) (3 diffs)
• manual-tests/array-buffer-memory.html (deleted)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-15  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r90592.
+        http://trac.webkit.org/changeset/90592
+        https://bugs.webkit.org/show_bug.cgi?id=64627
+
+        Causes crashes with the web audio async decoding API
+        (Requested by jamesr on #webkit).
+
+        * html/canvas/ArrayBuffer.cpp:
+        (WebCore::ArrayBuffer::~ArrayBuffer):
+        (WebCore::ArrayBuffer::tryAllocate):
+        * manual-tests/array-buffer-memory.html: Removed.
+
 2011-07-15  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp

@@ -26 +26 @@
 #include "config.h"
 #include "ArrayBuffer.h"
-
-#if USE(V8)
-#include "V8Binding.h"
-#endif
 
 #include <wtf/RefPtr.h>
@@ -81 +77 @@
 ArrayBuffer::~ArrayBuffer()
 {
-#if USE(V8)
-    v8::V8::AdjustAmountOfExternalAllocatedMemory(-m_sizeInBytes);
-#endif
     WTF::fastFree(m_data);
 }
@@ -99 +92 @@
             return 0;
     }
-    if (WTF::tryFastCalloc(numElements, elementByteSize).getValue(result)) {
-#if USE(V8)
-        v8::V8::AdjustAmountOfExternalAllocatedMemory(numElements * elementByteSize);
-#endif
+    if (WTF::tryFastCalloc(numElements, elementByteSize).getValue(result))
         return result;
-    }
     return 0;
 }