Changeset 91260 in webkit


Ignore:
Timestamp:
Jul 19, 2011 8:56:57 AM (13 years ago)
Author:
steveblock@google.com
Message:

REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property
https://bugs.webkit.org/show_bug.cgi?id=64730

Reviewed by Alexey Proskuryakov.

Covered by existing tests.

  • bridge/jni/v8/JNIUtilityPrivate.cpp:

(JSC::Bindings::jvalueToJavaValue):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r91256 r91260  
     12011-07-19  Steve Block  <steveblock@google.com>
     2
     3        REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property
     4        https://bugs.webkit.org/show_bug.cgi?id=64730
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Covered by existing tests.
     9
     10        * bridge/jni/v8/JNIUtilityPrivate.cpp:
     11        (JSC::Bindings::jvalueToJavaValue):
     12
    1132011-07-19  Vitaly Repeshko  <vitalyr@chromium.org>
    214
  • trunk/Source/WebCore/bridge/jni/v8/JNIUtilityPrivate.cpp

    r82950 r91260  
    248248        {
    249249            jstring javaString = static_cast<jstring>(value.l);
    250             const UChar* a = getUCharactersFromJStringInEnv(getJNIEnv(), javaString);
     250            const UChar* characters = getUCharactersFromJStringInEnv(getJNIEnv(), javaString);
    251251            // We take a copy to allow the Java String to be released.
    252             result.m_stringValue = String(a).threadsafeCopy();
    253             releaseUCharactersForJStringInEnv(getJNIEnv(), javaString, a);
     252            result.m_stringValue = String(characters, getJNIEnv()->GetStringLength(javaString));
     253            releaseUCharactersForJStringInEnv(getJNIEnv(), javaString, characters);
    254254        }
    255255        break;
Note: See TracChangeset for help on using the changeset viewer.